Bug 246386 - Better support for dependent branches
Summary: Better support for dependent branches
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency treegraph
 
Reported: 2022-10-11 20:35 PDT by Matt Woodrow
Modified: 2022-10-18 20:36 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-10-11 20:35:04 PDT
Unfortunately GitHub doesn't support dependent branches for cross-repo PRs, but I think we could support them a bit better on our side.

I frequently end up developing changes that have dependencies on other changes that haven't yet landed. Neither combining them into a single PR, nor just waiting until the previous one has merged are great options.

Running `git webkit pr` on a branch with dependencies mostly works, except that it creates the PR against 'main', so it also includes all the commits from dependent branches. See https://github.com/WebKit/WebKit/pull/4085.

This is somewhat ok, since it means that EWS works. Once the dependent branches have merged, I can just rebase and re-push the PR and the other commits will disappear.

I think ideally we'd skip putting the commit messages from the dependent branch commits into the PR description, and instead include a message to reviewers that those commits aren't (logically) part of this PR and shouldn't be reviewed. Maybe including links to the PRs where those commits can/should be reviewed?

I'm not sure if there's much else we can do to make it clearer on the GitHub review side.

We also get a lot of log spew on the client side when pushing them, looks like parsing of the commit message is failing in some way?
Comment 1 Radar WebKit Bug Importer 2022-10-18 20:36:19 PDT
<rdar://problem/101321713>