Bug 246381 - Git webkit should offer a way to file bugzilla issues from existing commits
Summary: Git webkit should offer a way to file bugzilla issues from existing commits
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-11 19:43 PDT by Matt Woodrow
Modified: 2022-10-18 14:30 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-10-11 19:43:13 PDT
It looks like `git webkit branch` will file a bugzilla issue for you, but there doesn't appear to be a way to do this from existing commits.

I generally create a branch myself (before making any changes), and then add frequent commits as I develop, squashing and interactive rebasing as the changes evolve. Frequently I create new (dependent) branches for later commits, when it's obvious that the scope exceeds what should be in a single atomic merge to WebKit.

Ideally there'd be a way to automatically file bugs for the commits that I end up with.

I think my ideal behaviour would be to have a `git webkit` subcommand that takes a revision range, looks for commits in that range that are using the standard template, but don't have the bugzilla line filled out, and files bugs using the contained description (short desc as title, any longer desc below as comment). It'd be extra cool if it checked the message for an existing radar, and linked the bugzilla issue to that if so. It could then edit the message of those commits to insert the newly filed bugs (and radars, if applicable?).

`git webkit pr` could also optionally invoke this, using the commit range that will be included in the PR.
Comment 1 Radar WebKit Bug Importer 2022-10-14 12:05:43 PDT
<rdar://problem/101181555>
Comment 2 Matt Woodrow 2022-10-18 14:30:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5513