Bug 246380 - webkit pr should have an option not to create a commit
Summary: webkit pr should have an option not to create a commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-10-11 19:08 PDT by Matt Woodrow
Modified: 2022-10-18 11:19 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-10-11 19:08:22 PDT 
I generally don't want `git webkit pr` to create new commits for me, since I prefer to manage my git state manually.

--no-add stops it from adding new files to the index, but it'll still create a new commit (or amend/squash) if there's anything staged.
Comment 1 Radar WebKit Bug Importer 2022-10-11 19:09:54 PDT 
<rdar://problem/101060897>
Comment 2 Matt Woodrow 2022-10-11 19:11:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5272
Comment 3 EWS 2022-10-13 11:40:24 PDT 
Committed 255495@main (72ad3b19fdd6): <https://commits.webkit.org/255495@main>

Reviewed commits have been landed. Closing PR #5272 and removing active labels.
Comment 4 EWS 2022-10-18 11:19:57 PDT 
Committed 252432.589@safari-7614-branch (8f84dd973596): <https://commits.webkit.org/252432.589@safari-7614-branch>

Reviewed commits have been landed. Closing PR #140 and removing active labels.