Bug 24638 – [GTK] HTML5 media tags do not work

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

If you visit the URI I added to the bug report you'll notice that the video doesn't play. There are two main problems, really:

1) MediaPlayerPrivate::duration is returning 0 because gst_element_query_duration returns true even though it isn't able to figure out the duration in time format.

2) Nothing calls MediaPlayerPrivate::repaint when the sink draws the frame in the surface, so the video only gets updated when expose events or other conditions force the repaint

[Gustavo Noronha (kov)]

3) When buffering the stream is not paused, so the video plays badly

[Gustavo Noronha (kov)]

Created attachment 28678 [details]
fix for duration

[Gustavo Noronha (kov)]

Created attachment 28679 [details]
fix repainting

[Gustavo Noronha (kov)]

Created attachment 28680 [details]
fix buffering

[Gustavo Noronha (kov)]

Created attachment 28681 [details]
enable passing tests

[Mark Rowe (bdash)]

Comment on attachment 28679 [details]
fix repainting

> +void mediaPlayerPrivateRepaintCallback(WebKitVideoSink* sink, gpointer data)
> +{
> +    MediaPlayerPrivate* playerPrivate = static_cast<MediaPlayerPrivate*>(data);
> +    playerPrivate->repaint();
> +}

The function should be declared static, and the name of the first argument omitted since it is unused.  You could probably do away with the local variable too without losing any clarity.

r=me

[Mark Rowe (bdash)]

Comment on attachment 28680 [details]
fix buffering

What happens here if I explicitly hit "play" while a large video is buffering?  It seems like the video would pause itself until it completes loading, even though it may have buffered sufficiently for it to be watchable.  Does that match the spec?

What happens if I hit play and then explicitly pause the video while it is still loading?  It seems like the video would start itself playing when it finishes loading.  Does that match the spec?

[Mark Rowe (bdash)]

Comment on attachment 28678 [details]
fix for duration

This seems as though it will treat a zero-length video as streaming?  Does that behavior match the spec and/or other browsers?

[Mark Rowe (bdash)]

Comment on attachment 28681 [details]
enable passing tests

It would be preferable for the comment to explain, with reference to a bug, why specific tests are disabled.

[Holger Freyther]

Comment on attachment 28678 [details]
fix for duration

sorry, due mark's comments I put it back to review.

[Gustavo Noronha (kov)]

(In reply to comment #10)
> (From update of attachment 28678 [details] [review])
> sorry, due mark's comments I put it back to review.
> 

I'm setting the review flag for duration to r+ again, after talking to Mark on IRC, and will add a FIXME comment pointing to a bug report in our bugzilla, refering to a bug on the gstreamer bugzilla.

[Gustavo Noronha (kov)]

(In reply to comment #7)
> (From update of attachment 28680 [details] [review])
> What happens here if I explicitly hit "play" while a large video is buffering? 
> It seems like the video would pause itself until it completes loading, even
> though it may have buffered sufficiently for it to be watchable.  Does that
> match the spec?
> 
> What happens if I hit play and then explicitly pause the video while it is
> still loading?  It seems like the video would start itself playing when it
> finishes loading.  Does that match the spec?

I'll have to investigate this more closely. By reading the spec I believe we need to at least set readyState and networkState to specific values, and we need to figure out if we need to check if the user explicitely paused while we were buffering. I'll study some more tomorrow.

[Gustavo Noronha (kov)]

Comment on attachment 28678 [details]
fix for duration

Landed as r41756, with comments addressed. Clearing review flag.

[Gustavo Noronha (kov)]

Comment on attachment 28679 [details]
fix repainting

Landed as r41757. Clearing review flag.

[Gustavo Noronha (kov)]

Comment on attachment 28681 [details]
enable passing tests

Landed as r41758. Clearing review flag.

[Gustavo Noronha (kov)]

Comment on attachment 28680 [details]
fix buffering

Forgot to clear review flag while I stufy html5 media stuff a bit more for this change.

[Gustavo Noronha (kov)]

*** Bug 16985 has been marked as a duplicate of this bug. ***