Bug 24637 - [GTK] Build fail when --enable-icon-database=no
Summary: [GTK] Build fail when --enable-icon-database=no
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-16 19:55 PDT by Jim Huang
Modified: 2009-05-09 19:17 PDT (History)
1 user (show)

See Also:

Attachments
Possible fix. (953 bytes, patch)
2009-03-16 19:57 PDT, Jim Huang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Huang 2009-03-16 19:55:43 PDT 
While configured as --enable-icon-database=no, the compilation fails with the following messages:
WebCore/bindings/js/ScriptObjectQuarantine.cpp:37:24: JSDatabase.h: No such file or directory
WebCore/bindings/js/ScriptObjectQuarantine.cpp:38:23: JSStorage.h: No such file or directory
WebCore/bindings/js/ScriptObjectQuarantine.cpp: In function `bool WebCore::getQuarantinedScriptObject(WebCore::Database*, WebCore::ScriptObject&)':
WebCore/bindings/js/ScriptObjectQuarantine.cpp:53: error: invalid use of undefined type `struct WebCore::Database'
WebCore/bindings/js/ScriptObjectQuarantine.h:36: error: forward declaration of `struct WebCore::Database'
Comment 1 Jim Huang 2009-03-16 19:57:36 PDT 
Created attachment 28675 [details]
Possible fix.

This patch attempts to fix build errors.
Comment 2 Jan Alonzo 2009-04-19 02:35:54 PDT 
Comment on attachment 28675 [details]
Possible fix.

> @@ -1946,6 +1944,8 @@
>  	WebCore/bindings/js/JSDatabaseCustom.cpp \
>  	WebCore/bindings/js/JSSQLResultSetRowListCustom.cpp \
>  	WebCore/bindings/js/JSSQLTransactionCustom.cpp \
> +        WebCore/bindings/js/ScriptObjectQuarantine.cpp \
> +        WebCore/bindings/js/ScriptObjectQuarantine.h \

There are extra lines in your patch. Please remove. Also, please add a ChangeLog while you're at it and set the "review:" flag to "+" when you're ready to have it reviewed.

Thanks,
Comment 3 Jan Alonzo 2009-04-19 02:47:01 PDT 
(In reply to comment #2)
> (From update of attachment 28675 [details] [review])
> > @@ -1946,6 +1944,8 @@
> >  	WebCore/bindings/js/JSDatabaseCustom.cpp \
> >  	WebCore/bindings/js/JSSQLResultSetRowListCustom.cpp \
> >  	WebCore/bindings/js/JSSQLTransactionCustom.cpp \
> > +        WebCore/bindings/js/ScriptObjectQuarantine.cpp \
> > +        WebCore/bindings/js/ScriptObjectQuarantine.h \
> 
> There are extra lines in your patch. Please remove. Also, please add a
> ChangeLog while you're at it and set the "review:" flag to "+" when you're
> ready to have it reviewed.

Correction: should set the review flat to "?".
Comment 4 Jan Alonzo 2009-05-09 19:17:23 PDT 
I just tried this and it works fine. Apparently, this has been fixed in r42709 - http://trac.webkit.org/changeset/42709.

Closing as WORKSFORME. Thanks.