Bug 24637 – [GTK] Build fail when --enable-icon-database=no

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKitGTK

[Jim Huang]

While configured as --enable-icon-database=no, the compilation fails with the following messages:
WebCore/bindings/js/ScriptObjectQuarantine.cpp:37:24: JSDatabase.h: No such file or directory
WebCore/bindings/js/ScriptObjectQuarantine.cpp:38:23: JSStorage.h: No such file or directory
WebCore/bindings/js/ScriptObjectQuarantine.cpp: In function `bool WebCore::getQuarantinedScriptObject(WebCore::Database*, WebCore::ScriptObject&)':
WebCore/bindings/js/ScriptObjectQuarantine.cpp:53: error: invalid use of undefined type `struct WebCore::Database'
WebCore/bindings/js/ScriptObjectQuarantine.h:36: error: forward declaration of `struct WebCore::Database'

[Jim Huang]

Created attachment 28675 [details]
Possible fix.

This patch attempts to fix build errors.

[Jan Alonzo]

Comment on attachment 28675 [details]
Possible fix.

> @@ -1946,6 +1944,8 @@
>  	WebCore/bindings/js/JSDatabaseCustom.cpp \
>  	WebCore/bindings/js/JSSQLResultSetRowListCustom.cpp \
>  	WebCore/bindings/js/JSSQLTransactionCustom.cpp \
> +        WebCore/bindings/js/ScriptObjectQuarantine.cpp \
> +        WebCore/bindings/js/ScriptObjectQuarantine.h \

There are extra lines in your patch. Please remove. Also, please add a ChangeLog while you're at it and set the "review:" flag to "+" when you're ready to have it reviewed.

Thanks,

[Jan Alonzo]

(In reply to comment #2)
> (From update of attachment 28675 [details] [review])
> > @@ -1946,6 +1944,8 @@
> >  	WebCore/bindings/js/JSDatabaseCustom.cpp \
> >  	WebCore/bindings/js/JSSQLResultSetRowListCustom.cpp \
> >  	WebCore/bindings/js/JSSQLTransactionCustom.cpp \
> > +        WebCore/bindings/js/ScriptObjectQuarantine.cpp \
> > +        WebCore/bindings/js/ScriptObjectQuarantine.h \
> 
> There are extra lines in your patch. Please remove. Also, please add a
> ChangeLog while you're at it and set the "review:" flag to "+" when you're
> ready to have it reviewed.

Correction: should set the review flat to "?".

[Jan Alonzo]

I just tried this and it works fine. Apparently, this has been fixed in r42709 - http://trac.webkit.org/changeset/42709.

Closing as WORKSFORME. Thanks.