Bug 246344 – Correct autocorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Anne van Kesteren]

For password/URL/email controls we do the wrong thing per https://github.com/web-platform-tests/wpt/pull/25073 and our proposed specification at https://github.com/whatwg/html/pull/5841.

Might want to wait with fixing this until the specification PR has landed.

[Radar WebKit Bug Importer]

<rdar://problem/101036922>

[Anne van Kesteren]

Per recent specification discussion we'll also have to change isEmpty() to isNull() here:

bool HTMLFormControlElement::shouldAutocorrect() const
{
    const AtomString& autocorrectValue = attributeWithoutSynchronization(autocorrectAttr);
    if (!autocorrectValue.isEmpty())
        return !equalLettersIgnoringASCIICase(autocorrectValue, "off"_s);
    if (RefPtr<HTMLFormElement> form = this->form())
        return form->shouldAutocorrect();
    return true;
}

This causes an additional failure in the tests.

[Anne van Kesteren]

Pull request: https://github.com/WebKit/WebKit/pull/32388

[EWS]

Committed 282792@main (28a8a4b35f33): <https://commits.webkit.org/282792@main>

Reviewed commits have been landed. Closing PR #32388 and removing active labels.