WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WORKSFORME
246319
encode Markable values without a separate isEmpty boolean
https://bugs.webkit.org/show_bug.cgi?id=246319
Summary
encode Markable values without a separate isEmpty boolean
Cameron McCormack (:heycam)
Reported
2022-10-10 21:53:54 PDT
We currently encode Markable values by writing a bool first representing whether the value is the special empty value. We should make use of the fact that the types used in Markable are designed to represent an "is empty" state without additional storage.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-10-10 21:54:14 PDT
<
rdar://problem/101014331
>
Cameron McCormack (:heycam)
Comment 2
2022-10-10 22:40:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/5227
Cameron McCormack (:heycam)
Comment 3
2022-10-11 14:31:42 PDT
Decided against doing this.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug