Bug 24630 - Move and tweak BUILDING_ON_* macro defines (fixes wx build)
Summary: Move and tweak BUILDING_ON_* macro defines (fixes wx build)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Wx
Depends on:
Blocks:
 
Reported: 2009-03-16 16:20 PDT by Kevin Ollivier
Modified: 2009-03-17 09:10 PDT (History)
0 users

See Also:


Attachments
Moves and tweaks the BUILDING_ON_* macros to fix non-Apple builds (5.57 KB, patch)
2009-03-16 16:22 PDT, Kevin Ollivier
no flags Details | Formatted Diff | Diff
Updated patch that uses the Platform.h defines in WebKit/mac as well. (5.72 KB, patch)
2009-03-16 22:34 PDT, Kevin Ollivier
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2009-03-16 16:20:41 PDT
Currently the wx port is broken because the BUILDING_ON_* macros are defined in the *Prefix.h files on Mac, which are only used by XCode for the Apple Mac port. 

To fix this, I've moved the macros into Platform.h and updated the Mac port's JSCore and WebCore projects to pull them from there. For parts of the Mac port that do not use config.h / Platform.h, I've left the defines in the *Prefix.h header but updated them to match the ones defined in Platform.h.
Comment 1 Kevin Ollivier 2009-03-16 16:22:12 PDT
Created attachment 28663 [details]
Moves and tweaks the BUILDING_ON_* macros to fix non-Apple builds
Comment 2 Kevin Ollivier 2009-03-16 22:34:56 PDT
Created attachment 28677 [details]
Updated patch that uses the Platform.h defines in WebKit/mac as well.
Comment 3 Mark Rowe (bdash) 2009-03-16 23:33:43 PDT
Comment on attachment 28677 [details]
Updated patch that uses the Platform.h defines in WebKit/mac as well.

r=me
Comment 4 Kevin Ollivier 2009-03-17 09:10:58 PDT
Landed in r41764, thanks!