Bug 24625 - Accessor to the selected index needed in PopupMenuChromium
Summary: Accessor to the selected index needed in PopupMenuChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All OS X 10.5
: P2 Normal
Assignee: Jay Campan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-16 13:07 PDT by Jay Campan
Modified: 2009-03-19 09:30 PDT (History)
1 user (show)

See Also:


Attachments
Adds the selectedIndex accessor to PopupMenuChromium (1.82 KB, patch)
2009-03-16 13:11 PDT, Jay Campan
dglazkov: review-
Details | Formatted Diff | Diff
Fixed indent. (1.84 KB, patch)
2009-03-17 15:48 PDT, Jay Campan
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Campan 2009-03-16 13:07:55 PDT
In order to implement the deletion of autofill items in Chromium, PopupMenuChromium should have a getter to the selected index.
Comment 1 Jay Campan 2009-03-16 13:11:00 PDT
Created attachment 28657 [details]
Adds the selectedIndex accessor to PopupMenuChromium
Comment 2 Dimitri Glazkov (Google) 2009-03-17 15:38:09 PDT
Comment on attachment 28657 [details]
Adds the selectedIndex accessor to PopupMenuChromium

> +++ WebCore/platform/chromium/PopupMenuChromium.h	(working copy)
> @@ -107,6 +107,10 @@ namespace WebCore {
>  
>          PopupListBox* listBox() const { return m_listBox.get(); }
>  
> +	// Gets the index of the item that the user is currently moused-over or
> +	// has selected with the keyboard up/down arrows.
> +	int selectedIndex() const;
> +

ident fail? :)
Comment 3 Jay Campan 2009-03-17 15:48:29 PDT
Created attachment 28706 [details]
Fixed indent.
Comment 4 Dimitri Glazkov (Google) 2009-03-17 15:51:30 PDT
Comment on attachment 28706 [details]
Fixed indent.

r=me. I'll land.
Comment 5 Dimitri Glazkov (Google) 2009-03-19 09:30:44 PDT
Landed as http://trac.webkit.org/changeset/41835.