Bug 246228 - [run-webkit-tests] Support user specifying variant directly
Summary: [run-webkit-tests] Support user specifying variant directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-10-07 12:02 PDT by Jonathan Bedard
Modified: 2022-10-11 06:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-10-07 12:02:39 PDT 
There are some WPT tests that are variants on a single file. run-webkit-tests treats arguments as file names, and a file name+variant will never match a file on disk. To make matters more complicated, we use `glob` so that users can pass things like `css*` to run-webkit-tests, `glob` respects `?` though, so we can't just blindly treat all paths with a ? in them as test variants.
Comment 1 Radar WebKit Bug Importer 2022-10-07 12:02:54 PDT 
<rdar://problem/100907445>
Comment 2 Jonathan Bedard 2022-10-07 12:04:37 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/5149
Comment 3 EWS 2022-10-07 18:27:37 PDT 
Committed 255305@main (f8b4d273d3df): <https://commits.webkit.org/255305@main>

Reviewed commits have been landed. Closing PR #5149 and removing active labels.
Comment 4 EWS 2022-10-11 06:54:09 PDT 
Committed 252432.520@safari-7614-branch (2ba2101f572b): <https://commits.webkit.org/252432.520@safari-7614-branch>

Reviewed commits have been landed. Closing PR #111 and removing active labels.