Bug 24608 - Missing include in KURLGoogle.cpp
Summary: Missing include in KURLGoogle.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: David Levin
Depends on:
Reported: 2009-03-15 09:01 PDT by Craig Schlenter
Modified: 2009-03-20 16:57 PDT (History)
0 users

See Also:

patch to add missing include (862 bytes, patch)
2009-03-15 09:03 PDT, Craig Schlenter
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Schlenter 2009-03-15 09:01:28 PDT
KURLGoogle.cpp uses printf when #ifndef NDEBUG is true which in turn means that stdio.h should be included in that situation. Found with gcc 4.4.0

I'll attach a patch.
Comment 1 Craig Schlenter 2009-03-15 09:03:18 PDT
Created attachment 28636 [details]
patch to add missing include

Only tested on linux with chromium.
Comment 2 Dimitri Glazkov (Google) 2009-03-20 14:26:11 PDT
Comment on attachment 28636 [details]
patch to add missing include

Don't forget to add a link to bug on ChangeLog entry when landing.
Comment 3 David Levin 2009-03-20 15:54:28 PDT
Please include a link to the bug in the changelog in the future.

Assigned to levin for landing.
Comment 4 David Levin 2009-03-20 16:57:35 PDT
Committed as r41881.