Bug 245974 – REBASELINE(255032@main): [ iOS ] imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html is a constant failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hercules Hjalmarsson]

imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html

Is a constant text failure on iOS ToT and since a rebaseline at 255032@main.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html

DIFF:
@@ -1,6 +1,6 @@

 PASS Test screen.orientation properties
-FAIL Test screen.orientation default values. assert_true: expected true got false
+PASS Test screen.orientation default values.
 FAIL Test the orientations and associated angles promise_test: Unhandled rejection with value: object "TypeError: document.documentElement.requestFullscreen is not a function. (In 'document.documentElement.requestFullscreen()', 'document.documentElement.requestFullscreen' is undefined)"
 PASS Test that screen.orientation properties are not writable
 PASS Test that screen.orientation is always the same object

[Radar WebKit Bug Importer]

<rdar://problem/100727075>

[Hercules Hjalmarsson]

This issue can be bisected to 255032@main using command:

run-webkit-tests --iterations=2  --ios-simulator  imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html

[Hercules Hjalmarsson]

This appears to be progression and just need to be rebaselined due to in 255032@main the entire test was rebaselined and went from:

@@ -1,8 +1,10 @@

-PASS Test screen.orientation properties
-FAIL Test screen.orientation default values. assert_true: expected true got false
+Harness Error (FAIL), message = Test named 'Test that screen.orientation values change if the orientation changes' specified 1 'cleanup' function, and 1 failed.
+
+FAIL Test screen.orientation properties screen.orientation is not an Object. (evaluating '"type" in screen.orientation')
+FAIL Test screen.orientation default values. undefined is not an object (evaluating 'screen.orientation.type')
 FAIL Test the orientations and associated angles promise_test: Unhandled rejection with value: object "TypeError: document.documentElement.requestFullscreen is not a function. (In 'document.documentElement.requestFullscreen()', 'document.documentElement.requestFullscreen' is undefined)"
-PASS Test that screen.orientation properties are not writable
+FAIL Test that screen.orientation properties are not writable undefined is not an object (evaluating 'screen.orientation.type')
 PASS Test that screen.orientation is always the same object
 FAIL Test that screen.orientation values change if the orientation changes promise_test: Unhandled rejection with value: object "TypeError: document.documentElement.requestFullscreen is not a function. (In 'document.documentElement.requestFullscreen()', 'document.documentElement.requestFullscreen' is undefined)"

To:
@@ -1,6 +1,6 @@

 PASS Test screen.orientation properties
-FAIL Test screen.orientation default values. assert_true: expected true got false
+PASS Test screen.orientation default values.
 FAIL Test the orientations and associated angles promise_test: Unhandled rejection with value: object "TypeError: document.documentElement.requestFullscreen is not a function. (In 'document.documentElement.requestFullscreen()', 'document.documentElement.requestFullscreen' is undefined)"
 PASS Test that screen.orientation properties are not writable
 PASS Test that screen.orientation is always the same object

But the line:
FAIL Test screen.orientation default values. assert_true: expected true got false

Is actually passing on iOS compared to macOS when running the test.

[EWS]

Test gardening commit 255097@main (0bc59aef25d0): <https://commits.webkit.org/255097@main>

Reviewed commits have been landed. Closing PR #4940 and removing active labels.

[Alexey Proskuryakov]

Is there anything left to do here?