WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245945
Make "onpointerlockchange" & "onpointerlockerror" enumerable
https://bugs.webkit.org/show_bug.cgi?id=245945
Summary
Make "onpointerlockchange" & "onpointerlockerror" enumerable
Ahmad Saleem
Reported
2022-10-02 05:32:00 PDT
Hi Team, I just noted that we are failing two tests in IDLHarness for "onpointerlockchange" & "onpointerlockerror": Link -
http://wpt.live/pointerlock/idlharness.window.html
It seems that it might be we are not following web-spec:
https://w3c.github.io/pointerlock/#extensions-to-the-document-interface
We have following:
https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/dom/Document%2BPointerLock.idl#L30
and we have "FIXME", I think (if not wrong) that making them "enumerable" will fix these tests as well I was not able to find related bug so I create a new but if it is duplicate, please mark so. Thanks
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2022-10-03 22:36:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4965
EWS
Comment 2
2022-10-04 22:33:10 PDT
Committed
255153@main
(9fb95a34c7e1): <
https://commits.webkit.org/255153@main
> Reviewed commits have been landed. Closing PR #4965 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-10-04 22:34:19 PDT
<
rdar://problem/100795827
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug