Bug 24593 – Minor renaming in Chromium port's ResourceRequest.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[John Abd-El-Malek]

This is part of http://codereview.chromium.org/46026.

[John Abd-El-Malek]

Created attachment 28612 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 28612 [details]
Patch

>Index: WebCore/ChangeLog
...
>[phone]  jabdelmalek  <set EMAIL_ADDRESS environment variable>

nit: need to add your email address.  also good to put your full name.

you can set the env vars REAL_NAME and EMAIL_ADDRESS to make this
automatic next time you run prepare-ChangeLog.

>+        Reviewed by NOBODY (OOPS!).
>+
>+		https://bugs.webkit.org/show_bug.cgi?id=24593
>+
>+		Added requestorID so we can track the request to its WebView without using frame (which was removed).
>+

nit: tabs need to be replaced with spaces


>Index: WebCore/platform/network/chromium/ResourceRequest.h
...
>+            , m_requestorID(0)
>+            , m_requestorPid(0)

webkit style would make this m_requestorPID, but even better (I think)
would be to go with m_requestorProcessID.  that way it is not as visually
confusing with m_requestorID.  verbose names is consistent with webkit
style ;-)

[John Abd-El-Malek]

Created attachment 28613 [details]
updated per comments

[Darin Fisher (:fishd, Google)]

Comment on attachment 28613 [details]
updated per comments

>Index: WebCore/platform/network/chromium/ResourceRequest.h

>+        // Te process id of the process from which this request originated. In

Te -> The

[John Abd-El-Malek]

Created attachment 28616 [details]
fixed spelling mistake

[Dmitry Titov]

Landed: http://trac.webkit.org/changeset/41694