Bug 24593 - Minor renaming in Chromium port's ResourceRequest.h
Summary: Minor renaming in Chromium port's ResourceRequest.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Dmitry Titov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 16:31 PDT by John Abd-El-Malek
Modified: 2009-03-13 17:54 PDT (History)
0 users

See Also:


Attachments
Patch (4.91 KB, patch)
2009-03-13 16:35 PDT, John Abd-El-Malek
fishd: review-
Details | Formatted Diff | Diff
updated per comments (5.15 KB, patch)
2009-03-13 17:07 PDT, John Abd-El-Malek
fishd: review+
Details | Formatted Diff | Diff
fixed spelling mistake (5.15 KB, patch)
2009-03-13 17:35 PDT, John Abd-El-Malek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2009-03-13 16:31:58 PDT
This is part of http://codereview.chromium.org/46026.
Comment 1 John Abd-El-Malek 2009-03-13 16:35:25 PDT
Created attachment 28612 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-03-13 16:45:50 PDT
Comment on attachment 28612 [details]
Patch

>Index: WebCore/ChangeLog
...
>+2009-03-13  jabdelmalek  <set EMAIL_ADDRESS environment variable>

nit: need to add your email address.  also good to put your full name.

you can set the env vars REAL_NAME and EMAIL_ADDRESS to make this
automatic next time you run prepare-ChangeLog.

>+        Reviewed by NOBODY (OOPS!).
>+
>+		https://bugs.webkit.org/show_bug.cgi?id=24593
>+
>+		Added requestorID so we can track the request to its WebView without using frame (which was removed).
>+

nit: tabs need to be replaced with spaces


>Index: WebCore/platform/network/chromium/ResourceRequest.h
...
>+            , m_requestorID(0)
>+            , m_requestorPid(0)

webkit style would make this m_requestorPID, but even better (I think)
would be to go with m_requestorProcessID.  that way it is not as visually
confusing with m_requestorID.  verbose names is consistent with webkit
style ;-)
Comment 3 John Abd-El-Malek 2009-03-13 17:07:14 PDT
Created attachment 28613 [details]
updated per comments
Comment 4 Darin Fisher (:fishd, Google) 2009-03-13 17:13:53 PDT
Comment on attachment 28613 [details]
updated per comments

>Index: WebCore/platform/network/chromium/ResourceRequest.h

>+        // Te process id of the process from which this request originated. In

Te -> The
Comment 5 John Abd-El-Malek 2009-03-13 17:35:45 PDT
Created attachment 28616 [details]
fixed spelling mistake
Comment 6 Dmitry Titov 2009-03-13 17:54:30 PDT
Landed: http://trac.webkit.org/changeset/41694