NEW 245929
Fix incorrectly positioned block element inside list-style-position:inside item 
https://bugs.webkit.org/show_bug.cgi?id=245929
Summary Fix incorrectly positioned block element inside list-style-position:inside item
Ahmad Saleem
Reported 2022-10-01 06:49:20 PDT
Hi Team, It might be duplicate of other bugs but I want to try this bug by merging below and see how it goes. Commit - https://chromium.googlesource.com/chromium/src/+/36d85fd5ae96048efcef076a209655ddf2bd02fe Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/835b3f86b66bb2f7c66045c353a458a60d43800f/Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#L111 _____ In case if I am not able to fix this, I will document my rationale etc. here. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-10-08 06:50:18 PDT
<rdar://problem/100933527>
Ahmad Saleem
Comment 2 2022-10-24 07:45:12 PDT
I tried but I am not able to resolve build errors and not able to find "isInside" equivalent in Webkit (I might be wrong and trying it right): https://github.com/WebKit/WebKit/pull/4900 Closing my PR for someone else to try.
zalan
Comment 3 2023-03-19 11:08:31 PDT
(In reply to Ahmad Saleem from comment #2) > I tried but I am not able to resolve build errors and not able to find > "isInside" equivalent in Webkit (I might be wrong and trying it right): I think it maps to RenderListMarker::isInside
Ahmad Saleem
Comment 4 2024-06-15 22:24:05 PDT
Latest PR attempt - https://github.com/WebKit/WebKit/pull/29373 It compiles and fixes last two failing CSS2 tests on WPT as well but it also lead to failing some legit WPT test: Rebaseline - fast/repaint/list-marker.html Legit failure - imported/w3c/web-platform-tests/css/css-lists/change-list-style-position-002.html Closing PR for time being.
Note You need to log in before you can comment on or make changes to this bug.