Bug 245901 - Shrink shorthandPropertyUsed and shorthandPropertyAppeared
Summary: Shrink shorthandPropertyUsed and shorthandPropertyAppeared
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on: 238888
Blocks:
  Show dependency treegraph
 
Reported: 2022-09-30 15:10 PDT by Oriol Brufau
Modified: 2022-10-01 08:23 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2022-09-30 15:10:11 PDT
StyleProperties::asTextInternal uses these 2 bitsets of size numCSSProperties.
But as the name implies, they are only used for shorthand properties, which since bug 238888 are sorted together.
So the bitset size could actually be lastShorthandProperty - firstShorthandProperty + 1.
The change would be from 505 to 88 according to https://searchfox.org/wubkat/source/__GENERATED__/WebCore/DerivedSources/CSSPropertyNames.h#525,536-537
Comment 1 Oriol Brufau 2022-09-30 15:23:24 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4882
Comment 2 EWS 2022-10-01 08:22:40 PDT
Committed 255059@main (6f687d430ca3): <https://commits.webkit.org/255059@main>

Reviewed commits have been landed. Closing PR #4882 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-10-01 08:23:17 PDT
<rdar://problem/100655929>