WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
245846
Fix warnings in curl backend
https://bugs.webkit.org/show_bug.cgi?id=245846
Summary
Fix warnings in curl backend
Don Olmstead
Reported
2022-09-29 13:32:12 PDT
Clang 15 is reporting warnings in the code C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:158:17: error: enumeration values 'OpCodeContinuation', 'OpCodePong', and 'OpCodeInvalid' not handled in switch [-Werror,-Wswitch] switch (opCode) { ^~~~~~ C:/GitHub/WebKit/Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:375:138: error: lambda capture 'isCrossOrigin' is not used [-Werror,-Wunused-lambda-capture] m_client->willPerformHTTPRedirection(WTFMove(response), WTFMove(request), [this, protectedThis = Ref { *this }, didChangeCredential, isCrossOrigin](const ResourceRequest& newRequest) { ~~^~~~~~~~~~~~~ Also check MSVC so we can turn warnings as errors on for WinCairo and PlayStation.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-10-06 13:33:18 PDT
<
rdar://problem/100867914
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug