WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24583
Need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener.
https://bugs.webkit.org/show_bug.cgi?id=24583
Summary
Need to change scope of constructor and destructor of V8ObjectEventListener f...
Jian Li
Reported
2009-03-13 12:16:58 PDT
We need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener.
Attachments
Proposed Patch
(1.12 KB, patch)
2009-03-13 12:19 PDT
,
Jian Li
dglazkov
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jian Li
Comment 1
2009-03-13 12:19:21 PDT
Created
attachment 28590
[details]
Proposed Patch
Dimitri Glazkov (Google)
Comment 2
2009-03-13 13:35:47 PDT
Comment on
attachment 28590
[details]
Proposed Patch Yikes. /me longs for the time when we will no longer be forked and produce these silly errors.
David Levin
Comment 3
2009-03-13 13:39:24 PDT
Assign to levin for landing.
Dmitry Titov
Comment 4
2009-03-13 13:40:55 PDT
reassigning to me for landing.
Dmitry Titov
Comment 5
2009-03-13 13:47:07 PDT
landed in
http://trac.webkit.org/changeset/41682
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug