RESOLVED FIXED 245774
[GTK][WPE] Wrong close status code returned when the client closes a WebSocket 
https://bugs.webkit.org/show_bug.cgi?id=245774
Summary [GTK][WPE] Wrong close status code returned when the client closes a WebSocket
Miguel Gomez
Reported 2022-09-28 03:00:57 PDT
This can reproduced with https://certification.bbctvapps.co.uk/act/test/networking/v1.3.1/websocket-client-initiated-closure/ When the WebSocket connection is closed, we return the close code provided by soup_websocket_connection_get_close_code(). But this value can be 0, which is an invalid return code, if the client abruptly closes the connection. We should return SOUP_WEBSOCKET_CLOSE_ABNORMAL in this case.
Attachments
Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2022-09-28 03:10:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4787
EWS
Comment 2 2022-09-29 01:32:10 PDT
Committed 254988@main (977e507ed577): <https://commits.webkit.org/254988@main> Reviewed commits have been landed. Closing PR #4787 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.