Bug 24577 - Fix layout test for v8: LayoutTests/fast/events/onload-single-line-comment.html
Summary: Fix layout test for v8: LayoutTests/fast/events/onload-single-line-comment.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Mike Belshe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 10:23 PDT by Mike Belshe
Modified: 2009-03-20 16:57 PDT (History)
0 users

See Also:

Attachments
patch (2.54 KB, patch)
2009-03-13 17:10 PDT, Mike Belshe 		fishd: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2009-03-13 10:23:06 PDT 
Event handlers with trailing comments fail.
Comment 1 Mike Belshe 2009-03-13 17:10:52 PDT 
Created attachment 28615 [details]
patch
Comment 2 Mike Belshe 2009-03-13 17:13:48 PDT 
In reviewing my patch, I discovered that someone else fixed the bug in parallel.

This patch is a little better in that it consolidates the code.append()s into fewer calls.
Comment 3 Darin Fisher (:fishd, Google) 2009-03-13 17:14:46 PDT 
Comment on attachment 28615 [details]
patch

LGTM
Comment 4 David Levin 2009-03-20 15:49:14 PDT 
Assign to levin for landing.
Comment 5 David Levin 2009-03-20 16:57:12 PDT 
Committed as r41880.