WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
245755
[WGSL] Implement hex float parsing
https://bugs.webkit.org/show_bug.cgi?id=245755
Summary
[WGSL] Implement hex float parsing
Dan Glastonbury
Reported
2022-09-27 15:38:36 PDT
WGSL doesn't support hex float parsing. With a test, such as: ``` TEST(WGSLConstLiteralTests, AbstractFloatLiteralHex) { const ConstLiteralTestCase<double> testCases[] = { { "0xa.fp+2"_s, 0xa.fp+2 }, { "0X.3"_s, 0X.3p+0 }, { "0X1.fp-4"_s, 0X1.fp-4 } }; for (const auto& testCase : testCases) { auto parseResult = parseLCharPrimaryExpression(testCase.input); EXPECT_TRUE(parseResult); auto expr = WTFMove(*parseResult); EXPECT_TRUE(expr->isAbstractFloatLiteral()); const auto& floatLiteral = downcast<WGSL::AST::AbstractFloatLiteral>(expr.get()); EXPECT_EQ(floatLiteral.value(), testCase.expectedValue); auto inputLength = testCase.input.length(); EXPECT_EQ(floatLiteral.span(), WGSL::SourceSpan(0, inputLength, inputLength, 0)); } } ```
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-09-27 15:39:19 PDT
<
rdar://problem/100479770
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug