Bug 245747 – Align "UA" stylesheet for "dialog" with HTML Spec and other browsers

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Forms

[Ahmad Saleem]

Hi Team,

I hope you are well.

I just wanted to raise this for aligning "dialog.css" with other browsers and see if it leads to more WPT Test passes:

Webkit is missing following compared to Blink:

dialog:modal {
user-select: text;
}

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/resources/html.css;l=1401?q=html.css

and compared to Gecko and Blink, we are missing:

dialog:not([open]) {
display: none;
}

^ this is technically there with dialog {} but I think moving to above would be more aligned with all browsers.

https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3

And let see what happens. Thanks!

[Tim Nguyen (:ntim)]

> dialog:not([open]) {
>   display: none;
> }

We do it slightly differently, but it's there: 
https://searchfox.org/wubkat/rev/cf0cfbaf1ad7728a145c06e3539170870bbb913f/Source/WebCore/css/dialog.css#12-17

> dialog:modal {
>   user-select: text;
> }

Same here, we implement this through inertness (similar to how Firefox does it): https://searchfox.org/wubkat/rev/cf0cfbaf1ad7728a145c06e3539170870bbb913f/Source/WebCore/rendering/style/RenderStyle.cpp#2934-2944