RESOLVED FIXED 245742
[webkit-patch] Parse non-utf characters 
https://bugs.webkit.org/show_bug.cgi?id=245742
Summary [webkit-patch] Parse non-utf characters
Jonathan Bedard
Reported 2022-09-27 10:53:18 PDT
When we are parsing patches and diffs, we should at least not crash when parsing non-utf characters, even if we can't accurately display or reason about such characters.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-09-27 10:53:37 PDT
<rdar://problem/100466774>
Jonathan Bedard
Comment 2 2022-09-27 10:54:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4759
Jonathan Bedard
Comment 3 2022-09-28 13:40:40 PDT
For posterity's sake, would like to address something brought up in a Slack thread about this change. It would be possible to make our style checker and commit message builder operate on bytes instead of strings, which would avoid needing to replace non UTF-8 characters, however, that would require pretty extensive changes to our style checker code. Given that we don't really expect lines with non UTF-8 characters to be handled correctly in the style checker anyways, replacing them so we can at least run the style checker over files with non UTF-8 characters seems prudent.
EWS
Comment 4 2022-09-28 13:44:14 PDT
Committed 254967@main (cd13c6e5c9e2): <https://commits.webkit.org/254967@main> Reviewed commits have been landed. Closing PR #4759 and removing active labels.
Ryan Reno
Comment 5 2022-09-29 09:32:04 PDT
*** Bug 245690 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 6 2022-09-29 11:12:43 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/4834
EWS
Comment 7 2022-12-12 15:36:55 PST
Committed 257761@main (3c2f6580b5c3): <https://commits.webkit.org/257761@main> Reviewed commits have been landed. Closing PR #4834 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.