Description: fast/text/hyphenate-avoid-orphaned-word.html This test was consistently passing until at 254439@main when it began to fail consistently. Reproduction steps: I can reproduce this on 254439@main but cannot reproduce it on 254438@main or earlier. Command: run-webkit-tests --iterations 50 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 -f --no-retry --release fast/text/hyphenate-avoid-orphaned-word.html History: https://results.webkit.org/?suite=layout-tests&test=fast%2Ftext%2Fhyphenate-avoid-orphaned-word.html&version_name=Monterey DIFF: @@ -17,13 +17,13 @@ RenderText {#text} at (7,7) size 330x176 text run at (7,7) width 245: "The chief difficulty Alice found" text run at (7,29) width 245: "at first was in managing her" - text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "-" + text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "\x{2010}" text run at (7,73) width 209: "ting its body tucked away, " - text run at (215,73) width 37: "com" + hyphen string "-" + text run at (215,73) width 37: "com" + hyphen string "\x{2010}" text run at (7,95) width 245: "fortably enough, under her arm," text run at (7,117) width 228: "with its legs hanging down, " text run at (234,117) width 103: "but generally," - text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "-" + text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "\x{2010}" text run at (7,161) width 39: "ened." RenderBlock (floating) {DIV} at (356,0) size 344x240 RenderBlock {P} at (0,16) size 344x18 @@ -39,13 +39,13 @@ RenderText {#text} at (7,7) size 330x176 text run at (7,7) width 245: "The chief difficulty Alice found" text run at (7,29) width 245: "at first was in managing her" - text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "-" + text run at (7,51) width 245: "flamingo: she succeeded in get" + hyphen string "\x{2010}" text run at (7,73) width 209: "ting its body tucked away, " - text run at (215,73) width 37: "com" + hyphen string "-" + text run at (215,73) width 37: "com" + hyphen string "\x{2010}" text run at (7,95) width 245: "fortably enough, under her arm," text run at (7,117) width 228: "with its legs hanging down, " text run at (234,117) width 103: "but generally," - text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "-" + text run at (7,139) width 330: "just as she had got its neck nicely straight" + hyphen string "\x{2010}" text run at (7,161) width 39: "ened." RenderBlock (floating) {DIV} at (4,240) size 344x240 RenderBlock {P} at (0,16) size 344x18
<rdar://problem/100459482>
I have marked this test as a consistent failure while this issue is investigated.
Test gardening commit 254915@main (73955d2e491c): <https://commits.webkit.org/254915@main> Reviewed commits have been landed. Closing PR #4752 and removing active labels.
Not Monterey-specific. I plan to remove [ Monterey ] from the test expectation.
Created attachment 463043 [details] Patch
Patch needs to also include removing the failure expectation lines that were added in 254915@main
(In reply to Darin Adler from comment #4) > Not Monterey-specific. I plan to remove [ Monterey ] from the test > expectation. mac-bigsur still needs [hyphen string "-"] AFAICT
(In reply to Darin Adler from comment #6) > Patch needs to also include removing the failure expectation lines that were > added in 254915@main yeah, I just noticed it! Thanks.
Created attachment 463044 [details] [fast-cq]Patch
Committed 255672@main (edc5ffd70956): <https://commits.webkit.org/255672@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463044 [details].
(In reply to zalan from comment #7) > (In reply to Darin Adler from comment #4) > > Not Monterey-specific. I plan to remove [ Monterey ] from the test > > expectation. > mac-bigsur still needs [hyphen string "-"] AFAICT This shows that we should not write [ NewRelease ] when there is a difference between newer and older releases. We should write something like [ NewRelease+ ].