/tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp: In constructor ‘WebKit::NativeWebMouseEvent::NativeWebMouseEvent(GdkEvent*, int, std::optional<WebCore::FloatSize>)’: /tmp/webkit2gtk-2.38.0/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp:36:21: error: ‘gdk_event_copy’ was not declared in this scope; did you mean ‘gst_event_copy’? 36 | , m_nativeEvent(gdk_event_copy(event)) | ^~~~~~~~~~~~~~
This needs to include GtkVersioning.h --- a/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp +++ b/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp @@ -27,6 +27,7 @@ #include "NativeWebMouseEvent.h" #include "WebEventFactory.h" +#include <Source/WebCore/platform/gtk/GtkVersioning.h> #include <gdk/gdk.h> namespace WebKit {
Shouldn't it be #include <WebCore/GtkVersioning.h> ?
(In reply to Claudio Saavedra from comment #2) > Shouldn't it be #include <WebCore/GtkVersioning.h> ? yes, sorry, I tested a complete build and it works now #include "WebEventFactory.h" +#include <WebCore/GtkVersioning.h> #include <gdk/gdk.h>
The issue is present in “main” as well, so I have removed the [2.28.0] tag from the summary. I can make sure this gets backported to the release branch 😉️
Pull request: https://github.com/WebKit/WebKit/pull/4789
Committed 254950@main (8b91cf150e8a): <https://commits.webkit.org/254950@main> Reviewed commits have been landed. Closing PR #4789 and removing active labels.