Bug 245718 - Fix calculation of direction for text form control elements with dir="auto"
Summary: Fix calculation of direction for text form control elements with dir="auto"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-26 21:40 PDT by Frédéric Wang (:fredw)
Modified: 2022-09-27 21:43 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2022-09-26 21:40:00 PDT 
It's calling HTMLElement::directionalityIfDirIsAuto here but this function may sometime return a nullopt: https://searchfox.org/wubkat/rev/cf0cfbaf1ad7728a145c06e3539170870bbb913f/Source/WebCore/html/HTMLTextFormControlElement.cpp#825
Comment 1 Frédéric Wang (:fredw) 2022-09-26 21:53:53 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4741
Comment 2 EWS 2022-09-27 21:42:35 PDT 
Committed 254943@main (3c75189741bc): <https://commits.webkit.org/254943@main>

Reviewed commits have been landed. Closing PR #4741 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-09-27 21:43:19 PDT 
<rdar://problem/100490959>