Bug 245694 – AX: AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

AXIsolatedTree::updateChildren doesn't propagate updates downwards when AccessibilityObject::m_subtreeDirty is true

[Radar WebKit Bug Importer]

<rdar://problem/100426498>

[Tyler Wilcock]

rdar://100245048

[Tyler Wilcock]

Created attachment 462631 [details]
Patch

[chris fleizach]

Comment on attachment 462631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462631&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598
> +            if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree())

this is nice to string these in a single if. is this a new ability

[Tyler Wilcock]

(In reply to chris fleizach from comment #4)
> Comment on attachment 462631 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462631&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:598
> > +            if (auto* liveChild = dynamicDowncast<AccessibilityObject>(newChildren[i].get()); liveChild && liveChild->hasDirtySubtree())
> 
> this is nice to string these in a single if. is this a new ability
Indeed! It came with C++17.

[EWS]

Committed 254899@main (523acc306f2b): <https://commits.webkit.org/254899@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462631 [details].