Bug 245677 - Reviewers who approve a PR after `validate-commiter-and-reviewer` should be included in the final Reviewed by line
Summary: Reviewers who approve a PR after `validate-commiter-and-reviewer` should be i...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-09-26 09:07 PDT by Wenson Hsieh
Modified: 2023-01-18 07:53 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-09-26 09:07:51 PDT 
In the GitHub workflow, if you have a patch that's

- Reviewed by A
- Tagged with `merge-queue`
- Passes the `validate-commiter-and-reviewer` check in merge queue.
- Reviewed by B
- Lands

...the "Reviewed by" line will only say "Reviewed by A", but it would be ideal to have "Reviewed by A and B".
Comment 1 Radar WebKit Bug Importer 2022-10-03 09:08:21 PDT 
<rdar://problem/100719648>
Comment 2 Jonathan Bedard 2023-01-18 07:53:34 PST 
I guess this would entail running the `validate-committer-and-reviewer` check right before landing.