WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24566
Add tests to isolate font choices and metrics
https://bugs.webkit.org/show_bug.cgi?id=24566
Summary
Add tests to isolate font choices and metrics
Pam Greene (IRC:pamg)
Reported
2009-03-12 15:59:56 PDT
Any layout test that produces a render tree and image implicitly depends on the font choices made and the metrics of those fonts, but it's difficult for a new port to isolate those differences. It would be helpful to have some tests that are intended only to document and verify the fonts used by layout tests and the sizes of their various characters.
Attachments
New tests + results
(888.50 KB, patch)
2009-03-12 16:02 PDT
,
Pam Greene (IRC:pamg)
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1
2009-03-12 16:02:59 PDT
Created
attachment 28564
[details]
New tests + results This includes Leopard results in platform/mac/. Should I move those to platform/mac-leopard/ and generate separate mac-tiger results?
Pam Greene (IRC:pamg)
Comment 2
2009-03-12 16:05:01 PDT
Bah, I'll remove the svn:executable properties before committing.
Darin Adler
Comment 3
2009-03-12 16:51:00 PDT
(In reply to
comment #1
)
> This includes Leopard results in platform/mac/. Should I move those to > platform/mac-leopard/ and generate separate mac-tiger results?
Generally the most futuristic version goes in platform/mac and then older versions overlay on top of that. So we could generate separate mac-tiger results for tests that need them, but the Leopard and newer results would go in platform/mac rather than platform/mac-leopard.
Pam Greene (IRC:pamg)
Comment 4
2009-03-13 09:03:53 PDT
Good to know. Meanwhile, I've now verified that the results here also pass on Tiger.
Pam Greene (IRC:pamg)
Comment 5
2009-03-24 15:30:53 PDT
Landed in
r41955
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug