Bug 24566 - Add tests to isolate font choices and metrics
Summary: Add tests to isolate font choices and metrics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pam Greene (IRC:pamg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-12 15:59 PDT by Pam Greene (IRC:pamg)
Modified: 2009-03-24 15:30 PDT (History)
0 users

See Also:


Attachments
New tests + results (888.50 KB, patch)
2009-03-12 16:02 PDT, Pam Greene (IRC:pamg)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pam Greene (IRC:pamg) 2009-03-12 15:59:56 PDT
Any layout test that produces a render tree and image implicitly depends on the font choices made and the metrics of those fonts, but it's difficult for a new port to isolate those differences. It would be helpful to have some tests that are intended only to document and verify the fonts used by layout tests and the sizes of their various characters.
Comment 1 Pam Greene (IRC:pamg) 2009-03-12 16:02:59 PDT
Created attachment 28564 [details]
New tests + results

This includes Leopard results in platform/mac/.  Should I move those to platform/mac-leopard/ and generate separate mac-tiger results?
Comment 2 Pam Greene (IRC:pamg) 2009-03-12 16:05:01 PDT
Bah, I'll remove the svn:executable properties before committing.
Comment 3 Darin Adler 2009-03-12 16:51:00 PDT
(In reply to comment #1)
> This includes Leopard results in platform/mac/.  Should I move those to
> platform/mac-leopard/ and generate separate mac-tiger results?

Generally the most futuristic version goes in platform/mac and then older versions overlay on top of that. So we could generate separate mac-tiger results for tests that need them, but the Leopard and newer results would go in platform/mac rather than platform/mac-leopard.
Comment 4 Pam Greene (IRC:pamg) 2009-03-13 09:03:53 PDT
Good to know.  Meanwhile, I've now verified that the results here also pass on Tiger.
Comment 5 Pam Greene (IRC:pamg) 2009-03-24 15:30:53 PDT
Landed in r41955.