WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
24564
Add test to ensure that the JS document wrapper is created in the correct context
https://bugs.webkit.org/show_bug.cgi?id=24564
Summary
Add test to ensure that the JS document wrapper is created in the correct con...
Pam Greene (IRC:pamg)
Reported
2009-03-12 15:23:11 PDT
Once upon a time, Chromium had a bug in which the JS wrapper for the document in an inner frame was created using the prototype chain from the outer frame if the document was accessed from the outer frame first. Add a test to catch that.
Attachments
New test + result
(2.94 KB, patch)
2009-03-12 15:25 PDT
,
Pam Greene (IRC:pamg)
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1
2009-03-12 15:25:37 PDT
Created
attachment 28560
[details]
New test + result
Alexey Proskuryakov
Comment 2
2009-03-13 03:37:52 PDT
Comment on
attachment 28560
[details]
New test + result r=me I think that the test could be slightly cleaner if it used iframe onload attribute, rather than relying on some script run in the subframe. But maybe that wouldn't trigger the bug for some reason?
Pam Greene (IRC:pamg)
Comment 3
2009-03-13 09:21:00 PDT
Hm... I'm not certain either. I'll go ahead and land this as it is for now, and ask the creator of the test to further improve it if he can. (It started out using timeouts and polling rather than cross-frame function calls.) Landed in
r41668
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug