Made this function custom to deal with the difference between DOMObject in the IDL and CanvasRenderingContext2D.
Created attachment 28557 [details] patch
Comment on attachment 28557 [details] patch Looks good, aside for helper functions. Also, don't forget to put bug URL in the ChangeLog. I usually do: URL Description. (standard stuff prepareChangelog puts in) > + String contextId = ToWebCoreString(args[0]); toWebCoreString > + String name = ToWebCoreString(args[1]); Ditto. > + int width = ToInt32(args[2]); toInt32 > + int height = ToInt32(args[3]); Ditto. > + CanvasRenderingContext2D* result = imp->getCSSCanvasContext(contextId, name, width, height); > + return V8Proxy::ToV8Object(V8ClassIndex::CANVASRENDERINGCONTEXT2D, result); > +} > + > } // namespace WebCore
Created attachment 28563 [details] updated patch
Landed as http://trac.webkit.org/changeset/41691.