RESOLVED FIXED 24562
Add custom V8 binding for Document.getCSSCanvasContext 
https://bugs.webkit.org/show_bug.cgi?id=24562
Summary Add custom V8 binding for Document.getCSSCanvasContext
Mike Belshe
Reported 2009-03-12 14:27:44 PDT
Made this function custom to deal with the difference between DOMObject in the IDL and CanvasRenderingContext2D.
Attachments
patch (1.47 KB, patch)
2009-03-12 14:36 PDT, Mike Belshe 		dglazkov: review+
DetailsFormatted DiffDiff
updated patch (1.44 KB, patch)
2009-03-12 15:56 PDT, Mike Belshe 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-12 14:36:53 PDT
Created attachment 28557 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-03-12 15:14:53 PDT
Comment on attachment 28557 [details] patch Looks good, aside for helper functions. Also, don't forget to put bug URL in the ChangeLog. I usually do: URL Description. (standard stuff prepareChangelog puts in) > + String contextId = ToWebCoreString(args[0]); toWebCoreString > + String name = ToWebCoreString(args[1]); Ditto. > + int width = ToInt32(args[2]); toInt32 > + int height = ToInt32(args[3]); Ditto. > + CanvasRenderingContext2D* result = imp->getCSSCanvasContext(contextId, name, width, height); > + return V8Proxy::ToV8Object(V8ClassIndex::CANVASRENDERINGCONTEXT2D, result); > +} > + > } // namespace WebCore
Mike Belshe
Comment 3 2009-03-12 15:56:01 PDT
Created attachment 28563 [details] updated patch
Dimitri Glazkov (Google)
Comment 4 2009-03-13 15:47:29 PDT
Landed as http://trac.webkit.org/changeset/41691.
Note You need to log in before you can comment on or make changes to this bug.