Custom implementations for v8.
Created attachment 28556 [details] patch
Comment on attachment 28556 [details] patch Looks good, except for very minor style nits: > + * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added. > + (WebCore::CALLBACK_FUNC_DECL): > + * bindings/v8/custom/V8LocationCustom.cpp: Added. > + (WebCore::navigateIfAllowed): > + (WebCore::ACCESSOR_SETTER): > + (WebCore::ACCESSOR_GETTER): > + (WebCore::CALLBACK_FUNC_DECL): > + (WebCore::INDEXED_ACCESS_CHECK): > + (WebCore::NAMED_ACCESS_CHECK): Remove func lines here unless there's a useful comment to go with them. > + v8::Handle<v8::Value> holder = args.Holder(); > + HTMLCanvasElement* imp = V8Proxy::DOMWrapperToNode<HTMLCanvasElement>(holder); > + String contextId = ToWebCoreString(args[0]); toWebCoreString > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } No braces for one-liners. > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } Ditto. > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } Ditto.
Created attachment 28562 [details] patch with updates
Landed as http://trac.webkit.org/changeset/41693.