RESOLVED FIXED 24561
Add custom V8 bindings for HTMLElementCanvas, Location 
https://bugs.webkit.org/show_bug.cgi?id=24561
Summary Add custom V8 bindings for HTMLElementCanvas, Location
Mike Belshe
Reported 2009-03-12 14:24:57 PDT
Custom implementations for v8.
Attachments
patch (17.38 KB, patch)
2009-03-12 14:36 PDT, Mike Belshe 		no flags
DetailsFormatted DiffDiff
patch with updates (17.09 KB, patch)
2009-03-12 15:53 PDT, Mike Belshe 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Belshe
Comment 1 2009-03-12 14:36:12 PDT
Created attachment 28556 [details] patch
Dimitri Glazkov (Google)
Comment 2 2009-03-12 15:10:26 PDT
Comment on attachment 28556 [details] patch Looks good, except for very minor style nits: > + * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added. > + (WebCore::CALLBACK_FUNC_DECL): > + * bindings/v8/custom/V8LocationCustom.cpp: Added. > + (WebCore::navigateIfAllowed): > + (WebCore::ACCESSOR_SETTER): > + (WebCore::ACCESSOR_GETTER): > + (WebCore::CALLBACK_FUNC_DECL): > + (WebCore::INDEXED_ACCESS_CHECK): > + (WebCore::NAMED_ACCESS_CHECK): Remove func lines here unless there's a useful comment to go with them. > + v8::Handle<v8::Value> holder = args.Holder(); > + HTMLCanvasElement* imp = V8Proxy::DOMWrapperToNode<HTMLCanvasElement>(holder); > + String contextId = ToWebCoreString(args[0]); toWebCoreString > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } No braces for one-liners. > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } Ditto. > + return sharedTemplate->GetFunction(); > + } else { > + return privateTemplate->GetFunction(); > + } Ditto.
Mike Belshe
Comment 3 2009-03-12 15:53:26 PDT
Created attachment 28562 [details] patch with updates
Dimitri Glazkov (Google)
Comment 4 2009-03-13 16:08:12 PDT
Landed as http://trac.webkit.org/changeset/41693.
Note You need to log in before you can comment on or make changes to this bug.