Bug 24557 - Add locker to v8 event listener of worker context.
Summary: Add locker to v8 event listener of worker context.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-12 13:46 PDT by Jian Li
Modified: 2009-03-13 10:34 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (1.15 KB, patch)
2009-03-12 13:50 PDT, Jian Li 		dglazkov: review+
Details | Formatted Diff | Diff
Proposed Patch (1.22 KB, patch)
2009-03-13 10:10 PDT, Jian Li 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-03-12 13:46:59 PDT 
Add locker to v8 event listener of worker context.
Comment 1 Jian Li 2009-03-12 13:50:07 PDT 
Created attachment 28548 [details]
Proposed Patch
Comment 2 Dimitri Glazkov (Google) 2009-03-13 09:35:09 PDT 
Comment on attachment 28548 [details]
Proposed Patch

> +        Bug 24557: Add locker to v8 event listener of worker context.
> +        https://bugs.webkit.org/show_bug.cgi?id=24557


This is probably more conventional and less redundant:

https://bugs.webkit.org/show_bug.cgi?id=24557
Add locker to v8 event listener of worker context.

Also, perhaps we could make the comment a little bit more informative? It sounds more like a description an action rather than the problem it aims to solve.
Comment 3 Jian Li 2009-03-13 10:10:52 PDT 
Created attachment 28579 [details]
Proposed Patch
Comment 4 Dimitri Glazkov (Google) 2009-03-13 10:20:00 PDT 
Comment on attachment 28579 [details]
Proposed Patch

I see you didn't take my first suggestion :). r=me, just try to make ChangeLog entries consistent with others'.

Also, the "Add locker to v8 event listener of worker context" probably belongs with 

+        (WebCore::V8WorkerContextEventListener::handleEvent):
Comment 5 David Levin 2009-03-13 10:21:21 PDT 
Assigned to levin for landing.
Comment 6 David Levin 2009-03-13 10:34:03 PDT 
Committed in r41670.