Bug 24553 - [GTK] Improvements to WebKitDownload
Summary: [GTK] Improvements to WebKitDownload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-03-12 11:56 PDT by Gustavo Noronha (kov)
Modified: 2009-03-12 12:33 PDT (History)
0 users

See Also:


Attachments
the doc fix (2.25 KB, patch)
2009-03-12 11:56 PDT, Gustavo Noronha (kov)
ap: review+
Details | Formatted Diff | Diff
rename state to status and make it a property (11.78 KB, patch)
2009-03-12 11:57 PDT, Gustavo Noronha (kov)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-03-12 11:56:22 PDT
We need a small documentation fix for the download-requested signal, and we decided to rename state to 'status', and make it a property, to match the frame loader signals rework we plan to land soonish (https://bugs.webkit.org/show_bug.cgi?id=17066).
Comment 1 Gustavo Noronha (kov) 2009-03-12 11:56:49 PDT
Created attachment 28537 [details]
the doc fix
Comment 2 Gustavo Noronha (kov) 2009-03-12 11:57:19 PDT
Created attachment 28538 [details]
rename state to status and make it a property
Comment 3 Gustavo Noronha (kov) 2009-03-12 11:57:55 PDT
I've adapted the download support in Epiphany to these changes and Epiphany keeps working perfectly.
Comment 4 Alexey Proskuryakov 2009-03-12 12:11:31 PDT
Comment on attachment 28537 [details]
the doc fix

r=me
Comment 5 Alexey Proskuryakov 2009-03-12 12:15:38 PDT
Comment on attachment 28538 [details]
rename state to status and make it a property

Looks fine, r=me
Comment 6 Gustavo Noronha (kov) 2009-03-12 12:33:32 PDT
Landed as r41638 and r41639.