RESOLVED WORKSFORME 24546
[x86_64] JITArithmetic does not build 
https://bugs.webkit.org/show_bug.cgi?id=24546
Summary [x86_64] JITArithmetic does not build
Gabor Loki
Reported 2009-03-12 06:03:55 PDT
On x86_64 a pointer should not be casted to unsigned int, like in ' __ cmpl_im(reinterpret_cast<unsigned>(numberStructure), FIELD_OFFSET(JSCell, m_structure), X86::edx)' expressions. uintptr_t should be used instead of unsigned. Additional, the suffixes or operands are invalid for 'push' and 'pop' in isSSE2Present if the compiler is GCC. I am going to attach a fix.
Attachments
Proposed fix for x86_64 (3.54 KB, patch)
2009-03-12 06:06 PDT, Gabor Loki 		ggaren: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2009-03-12 06:06:45 PDT
Created attachment 28527 [details] Proposed fix for x86_64
Eric Seidel (no email)
Comment 2 2009-05-11 06:01:36 PDT
This looks very simple to review. I'm surprised it's sat for 2 months in the queue. Any JS reviewers?
Geoffrey Garen
Comment 3 2009-05-11 09:53:33 PDT
Comment on attachment 28527 [details] Proposed fix for x86_64 There's no harm in this patch, but it won't work. On 64bit, you can't compare a pointer to a 32bit immediate. This code should be #ifdef'd out in a 64bit build.
Alexey Proskuryakov
Comment 4 2010-06-12 14:58:24 PDT
A build fix from early 2009 is almost certainly obsolete, closing the bug. Please feel free to re-open if you intend to follow up on this.
Note You need to log in before you can comment on or make changes to this bug.