Bug 24543 - Rename KURL::isLocalFile() to isFileURL()
Summary: Rename KURL::isLocalFile() to isFileURL()
Status: RESOLVED DUPLICATE of bug 257316
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-12 01:13 PDT by Julien Chaffraix
Modified: 2023-07-14 15:33 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2009-03-12 01:13:51 PDT 
This was raised during bug 22475.

To sum up what was said, isLocalFile is not totally right as the resource can be remote but mounted in the local filesystem. isFileURL would be more appropriate and stick to what the method is currently doing.
Comment 1 Julien Chaffraix 2009-03-12 01:38:22 PDT 
Darin, could you tell us your thoughts about this renaming?
Comment 2 Darin Adler 2009-03-12 08:53:01 PDT 
Seems OK.

I don't like the idea of repeating the class name, URL, in the function. Maybe it should be protocolIsFile to be a member of the "protocol" family of functions. If so, then it would be good to have a version that works on strings too, just like protocolIs. And have protocolIsJavaScript too.
Comment 3 Anne van Kesteren 2023-07-14 15:33:31 PDT 

*** This bug has been marked as a duplicate of bug 257316 ***