RESOLVED DUPLICATE of bug 25731624543
Rename KURL::isLocalFile() to isFileURL() 
https://bugs.webkit.org/show_bug.cgi?id=24543
Summary Rename KURL::isLocalFile() to isFileURL()
Julien Chaffraix
Reported 2009-03-12 01:13:51 PDT
This was raised during bug 22475. To sum up what was said, isLocalFile is not totally right as the resource can be remote but mounted in the local filesystem. isFileURL would be more appropriate and stick to what the method is currently doing.
Attachments
Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2009-03-12 01:38:22 PDT
Darin, could you tell us your thoughts about this renaming?
Darin Adler
Comment 2 2009-03-12 08:53:01 PDT
Seems OK. I don't like the idea of repeating the class name, URL, in the function. Maybe it should be protocolIsFile to be a member of the "protocol" family of functions. If so, then it would be good to have a version that works on strings too, just like protocolIs. And have protocolIsJavaScript too.
Anne van Kesteren
Comment 3 2023-07-14 15:33:31 PDT
*** This bug has been marked as a duplicate of bug 257316 ***
Note You need to log in before you can comment on or make changes to this bug.