Bug 24541 - Scrolling with home and end keys not always works
Summary: Scrolling with home and end keys not always works
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-03-11 19:38 PDT by Gustavo Noronha (kov)
Modified: 2009-03-12 08:01 PDT (History)
0 users

See Also:


Attachments
proposed fix (2.02 KB, patch)
2009-03-11 20:40 PDT, Gustavo Noronha (kov)
alp: review+
Details | Formatted Diff | Diff
also make this work correctly for page up/down (2.35 KB, patch)
2009-03-12 07:31 PDT, Gustavo Noronha (kov)
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-03-11 19:38:29 PDT
Pressing the home and end keys not always work, and some times doesn't scroll to the beginning/end of the page. Try opening this page, click the view, click the down arrow, then click home, for instance.
Comment 1 Gustavo Noronha (kov) 2009-03-11 20:40:02 PDT
Created attachment 28519 [details]
proposed fix
Comment 2 Gustavo Noronha (kov) 2009-03-12 06:12:45 PDT
I found that on some sites, such as orkut, pgdown/pgup also do not work at all. I'll add another patch for that here.
Comment 3 Gustavo Noronha (kov) 2009-03-12 07:31:10 PDT
Created attachment 28528 [details]
also make this work correctly for page up/down

If you want to test the problem/fix use the bugzilla review page. The top frame doesn't scroll correctly with pgup/down.
Comment 4 Alp Toker 2009-03-12 07:52:03 PDT
Comment on attachment 28528 [details]
also make this work correctly for page up/down

r=me

Hope we'll tidy up the keypress/scrolling code soon though.
Comment 5 Alp Toker 2009-03-12 07:52:30 PDT
Comment on attachment 28519 [details]
proposed fix

r=me

Will do until this code is cleaned up to get the basic functionality.
Comment 6 Gustavo Noronha (kov) 2009-03-12 07:54:49 PDT
(In reply to comment #4)
> (From update of attachment 28528 [details] [review])
> r=me
> 
> Hope we'll tidy up the keypress/scrolling code soon though.
> 

Yeah, like I said in the spacebar bug, and on IRC, I think we need to review scrolling as a whole for the GTK+ port. I'd like to start that by implementing Scrollview::scroll. Time allowing, I'll do it.
Comment 7 Gustavo Noronha (kov) 2009-03-12 08:01:06 PDT
Landed as r41624 and r41625.