In implementation of DateMath class is a name conflict with globally defined tzname in Symbian. The proposed solution is to replace the "tzname" with different name instead of using namespace qualifier (appeared to be less clumsy). Similarly, there doesn't appear to be any reason for a conditional change. See attached patch.
Created attachment 28513 [details] Proposed fix for bug 24537
The patch does a lot more than renaming tzname, even though that is all the changelog mentions. That's a bit misleading.
Your changelogs should also have a name rather than "Nokia User".
(In reply to comment #2) > The patch does a lot more than renaming tzname, even though that is all the > changelog mentions. That's a bit misleading. > The patch has 1 more (not a lot more) changes, which is PLATFORM(SYMBIAN) conditional stuff related to DST processing. You're right, it should not have been munched together. I will separate it, update the patch and submit the symbian related stuff as a new bug report.
Created attachment 28583 [details] Patch update for 24537 As discussed, I removed the SYMBIAN conditional changes from this change request (will file that at a later point separately). This new patch contains the renaming of "tzname" only.
Comment on attachment 28583 [details] Patch update for 24537 Seems OK. But if I had to change this, I'd prefer to change it to something less cryptic rather than more. Like timeZoneName, rather than tznm. r=me
(In reply to comment #6) > (From update of attachment 28583 [details] [review]) > Seems OK. But if I had to change this, I'd prefer to change it to something > less cryptic rather than more. Like timeZoneName, rather than tznm. > > r=me > Sure, I don't mind verbose names. Do you need another patch or can you fix that directly?
Name changed and landed in: http://trac.webkit.org/changeset/41685