WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245362
Use dynamicDowncast() in RenderBox::offsetFromContainer()
https://bugs.webkit.org/show_bug.cgi?id=245362
Summary
Use dynamicDowncast() in RenderBox::offsetFromContainer()
Nikolas Zimmermann
Reported
2022-09-19 06:33:01 PDT
When both if<Foo> + downcast<Foo> are used, dynamicDowncast() is preferred (less repetitive).
Attachments
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2022-09-19 06:34:30 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4482
EWS
Comment 2
2022-09-19 14:03:46 PDT
Committed
254644@main
(cfb088fd5663): <
https://commits.webkit.org/254644@main
> Reviewed commits have been landed. Closing PR #4482 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-09-19 14:04:25 PDT
<
rdar://problem/100138658
>
Nikolas Zimmermann
Comment 4
2022-09-19 14:45:33 PDT
Well, this is part of the work done for LBSE, but doesn't "block"
bug 90738
, removing that dependency again.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug