Bug 24535 – Missing line terminator chars (;)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Norbert Leser]

Various statements with macro calls, including in generated files, are missing missing line terminator character (;). This is ignored by most compilers but symbian compilers fail.

Patch will follow.

[Norbert Leser]

Created attachment 28510 [details]
Proposed fix for bug 24535

[Mark Rowe (bdash)]

These macros expand to code that already include the trailing semicolons.  Why is this change needed?

[Alexey Proskuryakov]

If we do this, we should arguably remove semicolons from macro definitions.

[Norbert Leser]

(In reply to comment #3)
> If we do this, we should arguably remove semicolons from macro definitions.
> 

I agree with your proposal - if it's just for the sake of consistency and cleanliness of the code.
In fact, as far as I can tell, the COMPILE_ASSERT macro in Assert.h is the only one that has an implicit ";"
It is common practice anyway to not have a trailing ";" in #define's

I'd be glad to update the patch with this change in Assert.h, if there's an agreement.

[Alexey Proskuryakov]

I think that would be nice as a cleanup patch, yes. It's extremely surprising that any compiler would choke on the current code though.

[Norbert Leser]

Created attachment 28580 [details]
Proposed fix for 24535 

I added Assertions.h (removal of trailing ";" from COMPILE_ASSERT macro definition) to this updated patch, as discussed.
Otherwise, unchanged to initial patch.

[Darin Adler]

Comment on attachment 28580 [details]
Proposed fix for 24535 

Seems OK, r=me

[David Levin]

Assigned to levin for landing.

Please add a link to the bug in the ChangeLog in the future and there is no need to leave this "WARNING: NO TEST CASES ADDED OR CHANGED" in the ChangeLog.

[David Levin]

Committed as r41879.

[Eric Seidel (no email)]

Comment on attachment 28510 [details]
Proposed fix for bug 24535

A later version of this was reviewed already.  Clearing review flag to remove from queue.