Bug 245347 – Latest css/css-color wpt has failing tests that need triage

• Status: NEW
• Component: CSS

[Sam Weinig]

The following new tests are failing:

  imported/w3c/web-platform-tests/css/css-color/at-color-profile-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/currentcolor-003.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-001.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-002.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-003.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-004.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-005.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-006.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-010.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-011.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-013.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-014.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-015.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-016.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-020.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-021.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-022.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-023.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/lch-009.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/lch-010.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/oklch-009.html [ ImageOnlyFailure ]
  imported/w3c/web-platform-tests/css/css-color/oklch-010.html [ ImageOnlyFailure ]

[Sam Weinig]

The deprecated-sameas* tests are due to not implementing a new requirement for some of the system-colors to have the same computed values as some others.

Fix tracked in https://bugs.webkit.org/show_bug.cgi?id=245533.

[Radar WebKit Bug Importer]

<rdar://problem/100389360>

[Karl Dubost]

Created attachment 476898 [details]
rendering in safari, firefox, chrome

Hmm there are still things failing. 

Let's take.
https://wpt.live/css/css-color/deprecated-sameas-001.html

the square is 

grey in Firefox, 
black in Chrome.
Top is blue, bottom is white in Safari.

    <div class="test"></div>
    <div class="ref"></div>

with 

@supports (color: ActiveBorder) {
    .test {
        background-color: ActiveBorder;
    }
}

and

.ref {
    background-color: ButtonBorder;
    width: 12em;
    height: 6em;
}



ActiveBorder  resolves to: rgb(0, 103, 244)
ButtonBorder resolves to: rgb(255, 255, 255)



The spec says:
ActiveBorder
Active window border. Same as ButtonBorder.
https://drafts.csswg.org/css-color-4/#deprecated-system-colors

So activeBorder should be white.

[Karl Dubost]

https://searchfox.org/wubkat/rev/ae89fb172f2f6dfa362aff8493e0e2978a9800d4/Source/WebCore/rendering/mac/RenderThemeMac.mm#498-502
```cpp
// The following colors would expose user appearance preferences to the web, and could be used for fingerprinting.
// These are available only when the web view opts into the system appearance.
case CSSValueWebkitFocusRingColor:
case CSSValueActiveborder:
    return focusRingColor(options);
```

I guess it's why it gets blue?

[Karl Dubost]

   Deprecated - sameAs -> another property 

* ActiveCaption (black) -> Canvas (white)
https://searchfox.org/wubkat/rev/ae89fb172f2f6dfa362aff8493e0e2978a9800d4/Source/WebCore/rendering/mac/RenderThemeMac.mm#535-536
```cpp
case CSSValueActivecaption:
    return @selector(windowFrameTextColor);
```


* AppWorkSpace (gray) -> Canvas (white)
https://searchfox.org/wubkat/rev/ae89fb172f2f6dfa362aff8493e0e2978a9800d4/Source/WebCore/rendering/mac/RenderThemeMac.mm#537-538
```cpp
case CSSValueAppworkspace:
    return @selector(headerColor);
```

etc.