WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245333
REGRESSION(
254574@main
): Triggers ASSERTS when running wpt tests
https://bugs.webkit.org/show_bug.cgi?id=245333
Summary
REGRESSION(254574@main): Triggers ASSERTS when running wpt tests
Philippe Normand
Reported
2022-09-18 04:28:13 PDT
Doing an ASSERT_NOT_REACHED() for a feature not implemented seems a bit odd. Usually notImplemented() is used instead. Test: imported/w3c/web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.html and more STDERR: SHOULD NEVER BE REACHED STDERR: /app/webkit/Source/WebKit/UIProcess/WebPageProxy.cpp(7093) : void WebKit::WebPageProxy::setTextIndicator(const WebCore::TextIndicatorData&, uint64_t)
Attachments
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2022-09-18 04:42:38 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4456
EWS
Comment 2
2022-09-18 08:19:08 PDT
Committed
254610@main
(b8caa5b21cd3): <
https://commits.webkit.org/254610@main
> Reviewed commits have been landed. Closing PR #4456 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug