Bug 24530 - width100percent-searchfield.html should be fixed for chromium.
Summary: width100percent-searchfield.html should be fixed for chromium.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: David Levin
Depends on:
Reported: 2009-03-11 16:52 PDT by David Levin
Modified: 2009-03-19 11:13 PDT (History)
1 user (show)

See Also:

Proposed fix. (5.01 KB, patch)
2009-03-11 17:14 PDT, David Levin
no flags Details | Formatted Diff | Diff
Proposed fix. (5.65 KB, patch)
2009-03-12 01:25 PDT, David Levin
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-03-11 16:52:50 PDT
This was broken by http://trac.webkit.org/changeset/39924 which enabled search fields for Windows, but chromium on windows doesn't support this.
Comment 1 David Levin 2009-03-11 17:14:23 PDT
Created attachment 28503 [details]
Proposed fix.
Comment 2 Darin Fisher (:fishd, Google) 2009-03-12 00:36:08 PDT
Comment on attachment 28503 [details]
Proposed fix.

>+++ b/WebCore/css/chromium/themeChromiumWin.css

themeWin.css is not in a subdirectory.  why should this one be?

>+ * Copyright (c) 2009, Google Inc. All rights reserved.

nit: Copyright (C) 2009 Google Inc. All rights reserved.

>+/* These styles override the default styling for HTML elements as defined in
>+   WebCore/css/themeWin.css. */
>+#include "../themeWin.css"
>+/* Windows should render input[type="search"] the same as input with no type.
>+   This search thing is an Apple-ism to get mac style search inputs. */
>+input[type="search"] {
>+    -webkit-box-sizing: content-box;

this rule is not obvious to me.  what is this correcting for?
Comment 3 David Levin 2009-03-12 01:25:02 PDT
Created attachment 28522 [details]
Proposed fix.

> themeWin.css is not in a subdirectory.  why should this one be?
Qt did so: http://trac.webkit.org/browser/trunk/WebCore/css/qt so I was following that, but you make a really good point about Win which is an early precedent, so I'll move it up.

About that css style question, I was restoring the style to be exactly what it was before the change reference in the ChangeLog. I thought I tried the change without it and the test failed but I was wrong, so I've removed it.
Comment 4 Darin Fisher (:fishd, Google) 2009-03-12 11:31:23 PDT
Comment on attachment 28522 [details]
Proposed fix.


Given that qt uses a subdirectory, it may be a good idea to ask about this on #webkit to see if there is an effort to move these files into subdirectories.
Comment 5 David Levin 2009-03-12 15:06:38 PDT
Committed r41652.

Comment 6 Eric Seidel (no email) 2009-03-18 00:51:49 PDT
Seems this is an OK temporary fix.  But we should really consider fixing to support type=search as something other than type=text.

HTML5 mentions (although doesn't say much) about search:

personally, I'm a huge fan of having a "winnowing search widget" as part of the web.

If we're not going to add support for it.  We should convince Apple to pull this CSS out into a themeWinApple.css file.
Comment 7 Ojan Vafai 2009-03-19 11:13:46 PDT
I agree with Eric. We should implement input type=search, just without the rounded corners as those are there for matching the aqua theme.

Here's the relevant Chrome bug: http://crbug.com/17