WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245295
Error: redefinition of 'gigacageEnabledForProcess' in JSCOnly MacOS Ports
https://bugs.webkit.org/show_bug.cgi?id=245295
Summary
Error: redefinition of 'gigacageEnabledForProcess' in JSCOnly MacOS Ports
bigsean123
Reported
2022-09-16 13:39:50 PDT
"bootywarrior@Bootys-MacBook-Air WebKit % ./Tools/Scripts/build-jsc --jsc-only --release --cmakeargs="-DENABLE_STATIC_JSC=ON -DCMAKE_CXX_FLAGS='-fsanitize-coverage=trace-pc-guard -O3'" + cmake -DPORT="JSCOnly" -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release -G Ninja -DDEVELOPER_MODE=ON -DENABLE_STATIC_JSC=ON -DCMAKE_CXX_FLAGS='-fsanitize-coverage=trace-pc-guard -O3' -DENABLE_FTL_JIT=ON "/Users/bootywarrior/Downloads/Webkit/latest/WebKit" -- The C compiler identification is AppleClang 13.1.6.13160021 -- The CXX compiler identification is AppleClang 13.1.6.13160021 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- The CMake build type is: Release -- Found Perl: /usr/bin/perl (found suitable version "5.30.3", minimum required is "5.10.0") -- Found PerlModules: TRUE found components: English FindBin JSON::PP -- Found Python: /Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/bin/python3.8 (found version "3.8.9") found components: Interpreter -- Found Ruby: /usr/bin/ruby (found suitable version "2.6.8", minimum required is "1.9") -- Enabling ccache: Setting ccache prefix for compiler. -- Performing Test C_COMPILER_SUPPORTS_-fno-strict-aliasing -- Performing Test C_COMPILER_SUPPORTS_-fno-strict-aliasing - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fno-strict-aliasing -- Performing Test CXX_COMPILER_SUPPORTS_-fno-strict-aliasing - Success -- Performing Test C_COMPILER_SUPPORTS_-fno-exceptions -- Performing Test C_COMPILER_SUPPORTS_-fno-exceptions - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fno-exceptions -- Performing Test CXX_COMPILER_SUPPORTS_-fno-exceptions - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fno-rtti -- Performing Test CXX_COMPILER_SUPPORTS_-fno-rtti - Success -- Performing Test C_COMPILER_SUPPORTS_-Wno-tautological-compare -- Performing Test C_COMPILER_SUPPORTS_-Wno-tautological-compare - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-tautological-compare -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-tautological-compare - Success -- Performing Test C_COMPILER_SUPPORTS_-Wcast-align -- Performing Test C_COMPILER_SUPPORTS_-Wcast-align - Success -- Performing Test C_COMPILER_SUPPORTS_-Wformat-security -- Performing Test C_COMPILER_SUPPORTS_-Wformat-security - Success -- Performing Test C_COMPILER_SUPPORTS_-Wmissing-format-attribute -- Performing Test C_COMPILER_SUPPORTS_-Wmissing-format-attribute - Success -- Performing Test C_COMPILER_SUPPORTS_-Wpointer-arith -- Performing Test C_COMPILER_SUPPORTS_-Wpointer-arith - Success -- Performing Test C_COMPILER_SUPPORTS_-Wundef -- Performing Test C_COMPILER_SUPPORTS_-Wundef - Success -- Performing Test C_COMPILER_SUPPORTS_-Wwrite-strings -- Performing Test C_COMPILER_SUPPORTS_-Wwrite-strings - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wcast-align -- Performing Test CXX_COMPILER_SUPPORTS_-Wcast-align - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wformat-security -- Performing Test CXX_COMPILER_SUPPORTS_-Wformat-security - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wmissing-format-attribute -- Performing Test CXX_COMPILER_SUPPORTS_-Wmissing-format-attribute - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wpointer-arith -- Performing Test CXX_COMPILER_SUPPORTS_-Wpointer-arith - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wundef -- Performing Test CXX_COMPILER_SUPPORTS_-Wundef - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wwrite-strings -- Performing Test CXX_COMPILER_SUPPORTS_-Wwrite-strings - Success -- Performing Test C_COMPILER_SUPPORTS_-Qunused-arguments -- Performing Test C_COMPILER_SUPPORTS_-Qunused-arguments - Success -- Performing Test C_COMPILER_SUPPORTS_-Wno-maybe-uninitialized -- Performing Test C_COMPILER_SUPPORTS_-Wno-maybe-uninitialized - Failed -- Performing Test C_COMPILER_SUPPORTS_-Wno-parentheses-equality -- Performing Test C_COMPILER_SUPPORTS_-Wno-parentheses-equality - Success -- Performing Test C_COMPILER_SUPPORTS_-Wno-misleading-indentation -- Performing Test C_COMPILER_SUPPORTS_-Wno-misleading-indentation - Success -- Performing Test C_COMPILER_SUPPORTS_-Wno-psabi -- Performing Test C_COMPILER_SUPPORTS_-Wno-psabi - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Qunused-arguments -- Performing Test CXX_COMPILER_SUPPORTS_-Qunused-arguments - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-maybe-uninitialized -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-maybe-uninitialized - Failed -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-parentheses-equality -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-parentheses-equality - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-misleading-indentation -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-misleading-indentation - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-psabi -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-psabi - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-noexcept-type -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-noexcept-type - Success -- Performing Test C_COMPILER_SUPPORTS_-pipe -- Performing Test C_COMPILER_SUPPORTS_-pipe - Success -- Performing Test CXX_COMPILER_SUPPORTS_-pipe -- Performing Test CXX_COMPILER_SUPPORTS_-pipe - Success -- Performing Test C_COMPILER_SUPPORTS_-Wall -- Performing Test C_COMPILER_SUPPORTS_-Wall - Success -- Performing Test C_COMPILER_SUPPORTS_-Wextra -- Performing Test C_COMPILER_SUPPORTS_-Wextra - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wall -- Performing Test CXX_COMPILER_SUPPORTS_-Wall - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wextra -- Performing Test CXX_COMPILER_SUPPORTS_-Wextra - Success -- Performing Test C_COMPILER_SUPPORTS_-fcolor-diagnostics -- Performing Test C_COMPILER_SUPPORTS_-fcolor-diagnostics - Success -- Performing Test C_COMPILER_SUPPORTS_-fdiagnostics-color=always -- Performing Test C_COMPILER_SUPPORTS_-fdiagnostics-color=always - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fcolor-diagnostics -- Performing Test CXX_COMPILER_SUPPORTS_-fcolor-diagnostics - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fdiagnostics-color=always -- Performing Test CXX_COMPILER_SUPPORTS_-fdiagnostics-color=always - Success -- Performing Test ATOMICS_ARE_BUILTIN -- Performing Test ATOMICS_ARE_BUILTIN - Success -- Performing Test STD_FILESYSTEM_IS_AVAILABLE -- Performing Test STD_FILESYSTEM_IS_AVAILABLE - Success -- Linker variant in use: UNKNOWN -- Linker supports thin archives - FALSE -- Linker supports split debug info - FALSE -- Linker supports --gdb-index - FALSE -- Linker supports --disable-new-dtags - FALSE -- Archiver variant in use: -- Archiver supports thin archives - FALSE -- Looking for features.h -- Looking for features.h - not found -- Looking for errno.h -- Looking for errno.h - found -- Looking for langinfo.h -- Looking for langinfo.h - found -- Looking for sys/mman.h -- Looking for sys/mman.h - found -- Looking for pthread_np.h -- Looking for pthread_np.h - not found -- Looking for sys/param.h -- Looking for sys/param.h - found -- Looking for sys/time.h -- Looking for sys/time.h - found -- Looking for sys/timeb.h -- Looking for sys/timeb.h - found -- Looking for linux/memfd.h -- Looking for linux/memfd.h - not found -- Looking for _aligned_malloc -- Looking for _aligned_malloc - not found -- Looking for IsDebuggerPresent -- Looking for IsDebuggerPresent - not found -- Looking for localtime_r -- Looking for localtime_r - found -- Looking for malloc_trim -- Looking for malloc_trim - not found -- Looking for strnstr -- Looking for strnstr - found -- Looking for timegm -- Looking for timegm - found -- Looking for vasprintf -- Looking for vasprintf - found -- Looking for regexec -- Looking for regexec - found -- Looking for MAP_ALIGNED -- Looking for MAP_ALIGNED - not found -- Looking for SHM_ANON -- Looking for SHM_ANON - not found -- Looking for timingsafe_bcmp -- Looking for timingsafe_bcmp - found -- Looking for SIGTRAP -- Looking for SIGTRAP - found -- Performing Test HAVE_STAT_BIRTHTIME_value -- Performing Test HAVE_STAT_BIRTHTIME_value - Success -- Performing Test HAVE_TM_GMTOFF_value -- Performing Test HAVE_TM_GMTOFF_value - Success -- Performing Test HAVE_TM_ZONE_value -- Performing Test HAVE_TM_ZONE_value - Success -- Looking for sys/types.h -- Looking for sys/types.h - found -- Looking for stdint.h -- Looking for stdint.h - found -- Looking for stddef.h -- Looking for stddef.h - found -- Check size of __int128_t -- Check size of __int128_t - done -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success -- Found Threads: TRUE -- Found ICU: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libicucore.tbd -- Using platform-specific CMakeLists: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/PlatformJSCOnly.cmake -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-missing-field-initializers -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-missing-field-initializers - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-cast-align -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-cast-align - Success -- Using platform-specific CMakeLists: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/wtf/PlatformJSCOnly.cmake -- Copying generate-unified-source-bundles.rb to: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/FuzzBuild/Release/WTF/Scripts -- Using platform-specific CMakeLists: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/JavaScriptCore/PlatformJSCOnly.cmake -- Performing Test CXX_COMPILER_SUPPORTS_-ffp-contract=off -- Performing Test CXX_COMPILER_SUPPORTS_-ffp-contract=off - Success -- Performing Test CXX_COMPILER_SUPPORTS_-fno-slp-vectorize -- Performing Test CXX_COMPILER_SUPPORTS_-fno-slp-vectorize - Success -- Using source list file: Sources.txt -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-array-bounds -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-array-bounds - Success -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/JavaScriptCore/shell/PlatformJSCOnly.cmake -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/ThirdParty/gtest/PlatformJSCOnly.cmake -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-undef -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-undef - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-stringop-truncation -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-stringop-truncation - Failed -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-suggest-attribute=format - Failed -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/PlatformJSCOnly.cmake -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Tools/PlatformJSCOnly.cmake -- Using platform-specific CMakeLists: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Tools/TestWebKitAPI/PlatformJSCOnly.cmake -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-dangling-else -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-dangling-else - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-sign-compare -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-sign-compare - Success -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-unused-parameter -- Performing Test CXX_COMPILER_SUPPORTS_-Wno-unused-parameter - Success -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/PerformanceTests/MallocBench/MallocBench/PlatformJSCOnly.cmake -- Platform-specific CMakeLists not found: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/PerformanceTests/PlatformJSCOnly.cmake -- Enabled features: -- ENABLE_STATIC_JSC ............................. ON -- Configuring done -- Generating done -- Build files have been written to: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/FuzzBuild/Release + cmake --build FuzzBuild/Release --config Release -- jsc testb3 testair testapi testmasm testdfg -j8 [135/2266] Building CXX object Source/...as/pas_segregated_page_config_kind.c.o clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated] [207/2266] Building CXX object Source/.../bmalloc.dir/bmalloc/ProcessCheck.mm.o FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/ProcessCheck.mm.o /opt/homebrew/bin/ccache /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DBUILDING_JSCONLY__ -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_bmalloc -DHAVE_CONFIG_H=1 -DPAS_BMALLOC=1 -DU_DISABLE_RENAMING=1 -D_GNU_SOURCE -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/libpas/src/libpas -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fsanitize-coverage=trace-pc-guard -O3 -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wno-missing-field-initializers -Wno-cast-align -std=c++20 -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/ProcessCheck.mm.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/ProcessCheck.mm.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/ProcessCheck.mm.o -c /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc/ProcessCheck.mm /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc/ProcessCheck.mm:35:6: error: redefinition of 'gigacageEnabledForProcess' bool gigacageEnabledForProcess() ^ /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc/ProcessCheck.h:39:13: note: previous definition is here inline bool gigacageEnabledForProcess() { return true; } ^ 1 error generated. [214/2266] Building CXX object Source/...les/bmalloc.dir/bmalloc/Gigacage.cpp.o ninja: build stopped: subcommand failed. bootywarrior@Bootys-MacBook-Air WebKit % git branch * (HEAD detached at 32854d2f3f58) main bootywarrior@Bootys-MacBook-Air WebKit % "
Attachments
Build error
(1.53 MB, text/plain)
2022-09-19 10:19 PDT
,
bigsean123
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
bigsean123
Comment 1
2022-09-16 13:45:20 PDT
Since it was defined here "/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc/ProcessCheck.h:39:13: note: previous definition is here inline bool gigacageEnabledForProcess() { return true; }" Wouldn't be simply to remove the bool from "/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/bmalloc/bmalloc/ProcessCheck.mm:35:6: error: redefinition of 'gigacageEnabledForProcess' bool gigacageEnabledForProcess()" ?
bigsean123
Comment 2
2022-09-16 13:49:40 PDT
Actually That was the wrong assumption of me considering it falls between the "#if !BPLATFORM(WATCHOS)" check.
Mark Lam
Comment 3
2022-09-19 09:10:02 PDT
(In reply to bigsean123 from
comment #2
)
> Actually That was the wrong assumption of me considering it falls between > the "#if !BPLATFORM(WATCHOS)" check.
Hi bigsea123, Does this mean your issue is resolved? Honestly, my gut feeling says that the root cause of your issue is ether: 1. You're missing a #include of some header file somewhere, or 2. Your project is misconfiguring some build-time flags in a way that is not supported by the project. My bet would be on (1). Anyway, are you still stuck, or is the issue resolved for you? Thanks.
bigsean123
Comment 4
2022-09-19 09:22:09 PDT
The last problem or issue I opened I build for purpose of coverage fuzzying.
https://bugs.webkit.org/show_bug.cgi?id=244751
After *That bug report* was fixed the build fixed I Used the same commands and the build worked flawlessly, I use the same build command on this commit and it fails with gigacage issues. But no I haven’t got the issue resolved.
Mark Lam
Comment 5
2022-09-19 09:37:04 PDT
@Yusuke, is --jsc-only supported on macOS?
Mark Lam
Comment 6
2022-09-19 09:53:04 PDT
Hi bigsean123, I just noticed that you're using the `--jsc-only` flag for build-jsc on macOS. This is not an officially supported configuration. Try removing the `--jsc-only` flag. build-jsc should only build jsc anyway.
bigsean123
Comment 7
2022-09-19 09:55:02 PDT
(In reply to Mark Lam from
comment #6
)
> Hi bigsean123, I just noticed that you're using the `--jsc-only` flag for > build-jsc on macOS. This is not an officially supported configuration. Try > removing the `--jsc-only` flag. build-jsc should only build jsc anyway.
Will try that and give feedback on the results.
bigsean123
Comment 8
2022-09-19 10:19:47 PDT
Created
attachment 462433
[details]
Build error This the result of build-jsc without --jsc-only... I'm if --jsc-only isn't officially supported for Darwin builds then why was this commit made for my other issue
https://github.com/WebKit/WebKit/pull/4015
. Is their any other way around this issue both build-jsc and build-jsc --jsc-only are producing errors, Weirdly build-jsc --jsc-only have been building just fine on most commits up until recently within the last month
Mark Lam
Comment 9
2022-09-19 10:26:02 PDT
(In reply to bigsean123 from
comment #8
)
> Created
attachment 462433
[details]
> Build error
Error message and details please.
> This the result of build-jsc without --jsc-only... > > I'm if --jsc-only isn't officially supported for Darwin builds then why was > this commit made for my other issue >
https://github.com/WebKit/WebKit/pull/4015
.
Best effort to support (as much as possible). Not an officially supported configuration.
> Is their any other way around this issue both build-jsc and build-jsc > --jsc-only are producing errors, > Weirdly build-jsc --jsc-only have been building just fine on most commits up > until recently within the last month
Would be helpful if we can actually see what the error is.
Mark Lam
Comment 10
2022-09-19 10:29:32 PDT
BTW, I think `-DENABLE_STATIC_JSC=ON` is another non-supported option for macOS.
bigsean123
Comment 11
2022-09-19 10:48:10 PDT
(In reply to Mark Lam from
comment #9
)
> (In reply to bigsean123 from
comment #8
) > > Created
attachment 462433
[details]
> > Build error > > Error message and details please. > > > > This the result of build-jsc without --jsc-only... > > > > I'm if --jsc-only isn't officially supported for Darwin builds then why was > > this commit made for my other issue > >
https://github.com/WebKit/WebKit/pull/4015
. > > Best effort to support (as much as possible). Not an officially supported > configuration. > > > Is their any other way around this issue both build-jsc and build-jsc > > --jsc-only are producing errors, > > Weirdly build-jsc --jsc-only have been building just fine on most commits up > > until recently within the last month > > Would be helpful if we can actually see what the error is.
I put it in the attachment in #
comment 8
Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/WTF-generated-files.hmap -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/WTF-own-target-headers.hmap -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/WTF-all-target-headers.hmap -iquote /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/WTF-project-headers.hmap -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/Debug/include -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/Debug/usr/local/include -I/tmp/WTF.dst/usr/local/include -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/local/include -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/DerivedSources-normal/arm64 -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/DerivedSources/arm64 -I/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat\=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wliteral-conversion -Wthread-safety -F/Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/Debug -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/System/Library/PrivateFrameworks -isystem /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/System.framework/PrivateHeaders -MMD -MT dependencies -MF /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/Objects-normal/arm64/double-conversion.d --serialize-diagnostics /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/Objects-normal/arm64/double-conversion.dia -c /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/wtf/dtoa/double-conversion.cc -o /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/Objects-normal/arm64/double-conversion.o /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/Objects-normal/arm64/double-conversion.dia:1:1: warning: Could not read serialized diagnostics file: error("Failed to open diagnostics file") (in target 'WTF' from project 'WTF') warning: Skipping duplicate build file in Compile Sources build phase: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm (in target 'JSCLLIntSettingsExtractor' from project 'JavaScriptCore') warning: Skipping duplicate build file in Compile Sources build phase: /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm (in target 'JSCLLIntOffsetsExtractor' from project 'JavaScriptCore') ** BUILD FAILED ** The following build commands failed: CompileC /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/FuzzBuildO32/WTF.build/Debug/WTF.build/Objects-normal/arm64/WTFConfig.o /Users/bootywarrior/Downloads/Webkit/latest/WebKit/Source/WTF/wtf/WTFConfig.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'WTF' from project 'WTF') (1 failure) make: *** [debug] Error 65
Mark Lam
Comment 12
2022-09-19 12:19:41 PDT
I think this might be an artifact of recent build system changes (and yes it's a bug). Try adding this to your env vars: USE_WORKSPACE=NO. Let me know if that make the issue go away. Thanks.
Mark Lam
Comment 13
2022-09-19 12:20:58 PDT
Hi bigsean123, one more thing: have you pulled the latest `main` branch? Just double checking in case.
Ben Nham
Comment 14
2022-09-19 12:25:40 PDT
From looking at the code it seems that the #defines in ProcessCheck.h and ProcessCheck.mm don't quite line up correctly when building for JSCOnly, since JSCOnly doesn't seem to provide a BPlatform macro. I can take a look at this later today. Please note that this (building JSCOnly as a static library on Darwin) isn't an officially supported config, so breakages like this may happen periodically. Our supported configs are covered by continuous bots so this shouldn't happen for those configs.
Radar WebKit Bug Importer
Comment 15
2022-09-19 12:29:20 PDT
<
rdar://problem/100133724
>
Ben Nham
Comment 16
2022-09-19 12:31:52 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4496
bigsean123
Comment 17
2022-09-19 12:34:24 PDT
(In reply to Ben Nham from
comment #14
)
> From looking at the code it seems that the #defines in ProcessCheck.h and > ProcessCheck.mm don't quite line up correctly when building for JSCOnly, > since JSCOnly doesn't seem to provide a BPlatform macro. I can take a look > at this later today. > > Please note that this (building JSCOnly as a static library on Darwin) isn't > an officially supported config, so breakages like this may happen > periodically. Our supported configs are covered by continuous bots so this > shouldn't happen for those configs.
In essence so is build-jsc and build-jsc --jsc-only the same thing, I don't know much about build and build commands, but I'm just using the build commands described for fuzzying that fuzzilli needs specify
https://github.com/googleprojectzero/fuzzilli/blob/8bfb44b818041d3eb9f9258614c6785c1a582fc8/Targets/JavaScriptCore/fuzzbuild.sh#L20
Lastly, so in reference. with MacOS don't use --jsc-only option as future commits for the main WebKit branch might break the building process?
Radar WebKit Bug Importer
Comment 18
2022-09-19 12:34:46 PDT
<
rdar://problem/100133952
>
Mark Lam
Comment 19
2022-09-19 12:44:09 PDT
(In reply to bigsean123 from
comment #17
)
> In essence so is build-jsc and build-jsc --jsc-only the same thing, I don't > know much about build and build commands
`--jsc-only` does not mean "only build jsc". JSCOnly is the name of a build configuration that is for linux.
> , but I'm just using the build > commands described for fuzzying that fuzzilli needs specify
fuzzilli targets linux AFAIK. As explained earlier, if you use --jsc-only for macOS, there's no guarantee it will work. It's primarily a linux build configuration.
Mark Lam
Comment 20
2022-09-19 12:49:02 PDT
(In reply to Mark Lam from
comment #19
)
> (In reply to bigsean123 from
comment #17
) > > In essence so is build-jsc and build-jsc --jsc-only the same thing, I don't > > know much about build and build commands > > `--jsc-only` does not mean "only build jsc". JSCOnly is the name of a build > configuration that is for linux. > > > , but I'm just using the build > > commands described for fuzzying that fuzzilli needs specify > > fuzzilli targets linux AFAIK. > > As explained earlier, if you use --jsc-only for macOS, there's no guarantee > it will work. It's primarily a linux build configuration.
I guess that fuzzily doc does specifically say that the invocation is intended for Darwin. However, that is only fuzzilli's choice to use the option. It is not the WebKit project's position to support that. Again, --jsc-only is not officially supported for macOS.
bigsean123
Comment 21
2022-09-19 13:25:58 PDT
(In reply to Mark Lam from
comment #20
)
> (In reply to Mark Lam from
comment #19
) > > (In reply to bigsean123 from
comment #17
) > > > In essence so is build-jsc and build-jsc --jsc-only the same thing, I don't > > > know much about build and build commands > > > > `--jsc-only` does not mean "only build jsc". JSCOnly is the name of a build > > configuration that is for linux. > > > > > , but I'm just using the build > > > commands described for fuzzying that fuzzilli needs specify > > > > fuzzilli targets linux AFAIK. > > > > As explained earlier, if you use --jsc-only for macOS, there's no guarantee > > it will work. It's primarily a linux build configuration. > > I guess that fuzzily doc does specifically say that the invocation is > intended for Darwin. However, that is only fuzzilli's choice to use the > option. It is not the WebKit project's position to support that. Again, > --jsc-only is not officially supported for macOS.
Yep I see the notion now, static builds and jsc-only ports aren't officially supported by Mac standards and can break easily for Mac in the future with commits.
bigsean123
Comment 22
2022-09-19 13:45:12 PDT
(In reply to Mark Lam from
comment #13
)
> Hi bigsean123, one more thing: have you pulled the latest `main` branch? > Just double checking in case.
yes I believe so, "make: *** [debug] Error 65 bootywarrior@Bootys-MacBook-Air WebKit % git branch * (HEAD detached at b9ccc0e90392) main bootywarrior@Bootys-MacBook-Air WebKit % " from my understanding when you pull from WebKit.git it automatically I set to main then the git checkout switches to the commit change version you specify, whether my understanding understanding/knowledge of how git and commits work is accurate or not is to be seen. but above I tanned git branch and it shows main and it sought to (head detached to commit listed.
Mark Lam
Comment 23
2022-09-19 19:58:46 PDT
<
rdar://problem/100133724
>
EWS
Comment 24
2022-09-19 21:04:28 PDT
Committed
254658@main
(b2518c25355d): <
https://commits.webkit.org/254658@main
> Reviewed commits have been landed. Closing PR #4496 and removing active labels.
bigsean123
Comment 25
2022-09-20 10:32:02 PDT
@Ben Nham Seems like the bug report I opened 2 weeks ago that you fixed here:
https://bugs.webkit.org/show_bug.cgi?id=244751
was regressed or something due to this commit for this error, Seems like @Mark Lam was right about the slightest change breaking --jsc-only on MacOS Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib/libicucore.tbd lib/libbmalloc.a && : Undefined symbols for architecture arm64: "_initializeLibraryPathDiagnostics", referenced from: void std::__1::__call_once_proxy<std::__1::tuple<WTF::initialize()::$_1&&> >(void*) in libWTF.a(Threading.cpp.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation) [746/756] Building CXX object Source/J...eFiles/testb3.dir/__/b3/testb3_2.cpp.o ninja: build stopped: subcommand failed. was fixed here
https://github.com/WebKit/WebKit/pull/4015
I believe.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug