WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245211
Remove 'KHTMLNowrap' and 'CSSWebkitNowrap' since now it is not used after Tables Quirk
https://bugs.webkit.org/show_bug.cgi?id=245211
Summary
Remove 'KHTMLNowrap' and 'CSSWebkitNowrap' since now it is not used after Tab...
Ahmad Saleem
Reported
2022-09-15 00:27:51 PDT
Hi Team, No other browser support KHTML Nowarp and we also removed the last usage in
Bug 183642
. I am thinking of removing it from:
https://github.com/WebKit/WebKit/blob/c888c485b787e204057b56d69536aae567ab8b3a/Source/WebCore/rendering/style/RenderStyleConstants.h#L708
https://github.com/WebKit/WebKit/blob/8fd683703b324056047dcbb939050b4b4f159eff/Source/WebCore/rendering/style/RenderStyleConstants.cpp#L1251
https://github.com/WebKit/WebKit/blob/11dc05a5914734bd841eb8a66e7034352d9a61b4/Source/WebCore/css/CSSPrimitiveValueMappings.h#L2826
https://github.com/WebKit/WebKit/blob/11dc05a5914734bd841eb8a66e7034352d9a61b4/Source/WebCore/css/CSSPrimitiveValueMappings.h#L2840
This just removal of dead code and it will not impact any test case or any web-exposed feature drastically since no other browser have it. Just creating a bug to do later on. Thank!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-09-16 07:31:59 PDT
Committed
254556@main
(719db0d99a39): <
https://commits.webkit.org/254556@main
> Reviewed commits have been landed. Closing PR #4373 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-09-16 07:32:18 PDT
<
rdar://problem/100026288
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug