Bug 24520 - Add test cases to check lookup precedence of DOM constructors
Summary: Add test cases to check lookup precedence of DOM constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pam Greene (IRC:pamg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-11 14:01 PDT by Pam Greene (IRC:pamg)
Modified: 2009-03-13 10:10 PDT (History)
0 users

See Also:


Attachments
Modified test + new results (4.21 KB, patch)
2009-03-11 14:04 PDT, Pam Greene (IRC:pamg)
no flags Details | Formatted Diff | Diff
Test for name too (5.11 KB, patch)
2009-03-12 12:56 PDT, Pam Greene (IRC:pamg)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pam Greene (IRC:pamg) 2009-03-11 14:01:59 PDT
Make sure DOM constructors have higher lookup precedence than a document element with the same name.
Comment 1 Pam Greene (IRC:pamg) 2009-03-11 14:04:31 PDT
Created attachment 28490 [details]
Modified test + new results
Comment 2 Alexey Proskuryakov 2009-03-12 01:16:32 PDT
Comment on attachment 28490 [details]
Modified test + new results

> +        Add test cases to ensure that DOM constructors have higher lookup
> +        precedence than a document element with the same name.

The test uses id, not name - is that intentional? Should it test both?
Comment 3 Pam Greene (IRC:pamg) 2009-03-12 12:56:34 PDT
Created attachment 28543 [details]
Test for name too

ID is the case that had a problem (http://code.google.com/p/v8/issues/detail?id=43), but sure, let's test name too.
Comment 4 Alexey Proskuryakov 2009-03-13 03:46:10 PDT
Comment on attachment 28543 [details]
Test for name too

r=me, assuming that the new results match Firefox.
Comment 5 Pam Greene (IRC:pamg) 2009-03-13 10:10:20 PDT
WebKit and Firefox don't match in their previously tested behavior: WebKit has constructors for several objects that Firefox doesn't. So FF fails some cases in this test, but no new failures show up due to these test-case additions. That is, in those cases where FF has a constructor at all, its lookup precedence matches ours.

Landed as r41669.