Bug 24515 - [GTK] soup backend should use GMappedFile instead of mmap directly
Summary: [GTK] soup backend should use GMappedFile instead of mmap directly
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk, Soup
Depends on:
Reported: 2009-03-11 06:46 PDT by Gustavo Noronha (kov)
Modified: 2009-03-12 05:00 PDT (History)
0 users

See Also:

proposed patch (4.48 KB, patch)
2009-03-11 06:47 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
proposed patch fixed (4.80 KB, patch)
2009-03-11 07:25 PDT, Gustavo Noronha (kov)
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-03-11 06:46:39 PDT
People have reported problems building WebKitGTK+ in Windows because of our usage of mmap/munmap in ResourceHandleSoup.cpp; glib provides a solution to this problem called GMappedFile, already, so we should use it.
Comment 1 Gustavo Noronha (kov) 2009-03-11 06:47:27 PDT
Created attachment 28478 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2009-03-11 07:25:00 PDT
Created attachment 28479 [details]
proposed patch fixed

Addressed comments by zecke on IRC.
Comment 3 Gustavo Noronha (kov) 2009-03-12 05:00:03 PDT
Landed as .r41610