Bug 245109 - [LFC][IFC] InlineFormattingGeometry::floatConstraintsForLine should not always flip for right-to-left direction
Summary: [LFC][IFC] InlineFormattingGeometry::floatConstraintsForLine should not alway...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-09-12 19:26 PDT by zalan
Modified: 2022-09-14 06:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (5.25 KB, patch)
2022-09-12 19:35 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.12 KB, patch)
2022-09-12 19:37 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (6.12 KB, patch)
2022-09-13 06:30 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (1.19 KB, patch)
2022-09-13 18:21 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-09-12 19:26:35 PDT
only when the floating context is in left to right mode.
Comment 1 zalan 2022-09-12 19:35:40 PDT
Created attachment 462300 [details]
Patch
Comment 2 zalan 2022-09-12 19:37:32 PDT
Created attachment 462301 [details]
Patch
Comment 3 Antti Koivisto 2022-09-13 06:11:39 PDT
Comment on attachment 462301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462301&action=review

> COMMIT_MESSAGE:14
> +while this does not need on:

one
Comment 4 zalan 2022-09-13 06:30:02 PDT
Created attachment 462316 [details]
[fast-cq]Patch
Comment 5 EWS 2022-09-13 06:44:36 PDT
Committed 254435@main (52561bcb85e3): <https://commits.webkit.org/254435@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462316 [details].
Comment 6 Radar WebKit Bug Importer 2022-09-13 06:45:21 PDT
<rdar://problem/99868841>
Comment 7 zalan 2022-09-13 18:21:45 PDT
Reopening to attach new patch.
Comment 8 zalan 2022-09-13 18:21:47 PDT
Created attachment 462325 [details]
Patch
Comment 9 EWS 2022-09-14 06:06:11 PDT
Committed 254474@main (2369ed44a124): <https://commits.webkit.org/254474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462325 [details].