Bug 24509 - Div for cancel button in search fields is too short
Summary: Div for cancel button in search fields is too short
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-10 21:53 PDT by Simon Fraser (smfr)
Modified: 2009-03-12 10:32 PDT (History)
1 user (show)

See Also:

Attachments
Repaint test result showing short rect (4.15 KB, image/png)
2009-03-10 21:55 PDT, Simon Fraser (smfr) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-03-10 21:53:02 PDT 
The repaint test that I'm about to commit for bug 23093 shows that the cancel button's renderer is 13x11px, which is too short. This causes incomplete redraws. It also makes the bottom 2px of the cancel button onclickable.

The cancel button size is hard-coded in RenderThemeMac to be 13x11px at normal font sizes. It draws correctly because when drawing, we call [NSSearchFieldCell cancelButtonRectForBounds:], which returns a rect that is 19x19px.

Note that just changing the cancelButtonSizes constants causes the search field to layout incorrectly.
Comment 1 Simon Fraser (smfr) 2009-03-10 21:55:28 PDT 
Created attachment 28463 [details]
Repaint test result showing short rect
Comment 2 Simon Fraser (smfr) 2009-03-12 10:32:33 PDT 
When fixing this, should also fix the cancel button with zooming.