WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
245061
[WGSL] Run WGSL unit tests on EWS
https://bugs.webkit.org/show_bug.cgi?id=245061
Summary
[WGSL] Run WGSL unit tests on EWS
Dan Glastonbury
Reported
2022-09-11 22:20:54 PDT
We have WGSLUnitTests, which is an XCTest-based unit tests for WGSL parsing, which aren't currently run on EWS. We should work out how to do that.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-09-11 22:21:29 PDT
<
rdar://problem/99808942
>
Dan Glastonbury
Comment 2
2022-09-11 22:30:32 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4247
Dan Glastonbury
Comment 3
2022-09-13 18:41:49 PDT
Ported Lexer and Parser tests to gtest to run in EWS.
EWS
Comment 4
2022-09-19 18:05:27 PDT
Committed
254654@main
(5bda1cab2367): <
https://commits.webkit.org/254654@main
> Reviewed commits have been landed. Closing PR #4247 and removing active labels.
Ryan Haddad
Comment 5
2022-09-22 13:25:01 PDT
Reverted in
https://commits.webkit.org/254764@main
due to this change breaking the watchOS and tvOS builds.
Dan Glastonbury
Comment 6
2022-09-22 19:35:54 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4615
EWS
Comment 7
2022-09-23 18:08:06 PDT
Committed
254813@main
(3561019e2cc1): <
https://commits.webkit.org/254813@main
> Reviewed commits have been landed. Closing PR #4615 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug